atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry <ames...@hortonworks.com>
Subject Re: Review Request 66534: Migration: Import: Support for BigDecimal, BigInteger.
Date Wed, 11 Apr 2018 21:10:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66534/
-----------------------------------------------------------

(Updated April 11, 2018, 9:10 p.m.)


Review request for atlas, Madhan Neethiraj and Ruchi Solani.


Changes
-------

Updates include:
- Support for BigDecimal, BigInteger data types.
- Additional unit tests.


Summary (updated)
-----------------

Migration: Import: Support for BigDecimal, BigInteger.


Bugs: ATLAS-2555
    https://issues.apache.org/jira/browse/ATLAS-2555


Repository: atlas


Description (updated)
-------

**Background**
Migration from HDP 2.6.x to HDP 3.x has a process based on GraphSON format.

Add support for BigDecimal, BigInteger data types.

**Implementation**
This patch contains unit tests for the module.

General approach:
- JSON files for exports from older version are used as resources. 
- Each of the key elements have a corresponding test. 

Description:
- _BaseUtils_: Base class from which all tests are derived. This has helper methods to load
various resources.
- _WorkItemManagerTest_: Simple usage.


Diffs
-----

  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONUtility.java
51209354 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/JsonNodeParsers.java
acf8cb2b 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/JsonNodeProcessManager.java
c1e9d204 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/MappedElementCache.java
fe9e3272 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/PostProcessManager.java
4c5e357a 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/ReaderStatusManager.java
67dbf225 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/RelationshipTypeCache.java
48b35958 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/pc/WorkItemConsumer.java
5de8db9a 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/pc/WorkItemManager.java
7e21495d 
  graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java
PRE-CREATION 
  graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONUtilityPostProcessTest.java
PRE-CREATION 
  graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONUtilityTest.java
PRE-CREATION 
  graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/JsonNodeParsersTest.java
PRE-CREATION 
  graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/MappedElementCacheTest.java
PRE-CREATION 
  graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/ReaderStatusManagerTest.java
PRE-CREATION 
  graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/WorkItemConsumerTest.java
PRE-CREATION 
  graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/WorkItemManagerTest.java
PRE-CREATION 
  graphdb/janus/src/test/resources/atlas-migration-data.json PRE-CREATION 
  graphdb/janus/src/test/resources/col-legacy.json PRE-CREATION 
  graphdb/janus/src/test/resources/db-type-legacy.json PRE-CREATION 
  graphdb/janus/src/test/resources/db-v-65544.json PRE-CREATION 
  graphdb/janus/src/test/resources/edge-legacy.json PRE-CREATION 
  graphdb/janus/src/test/resources/table-v-147504.json PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/impexp/MigrationProgressService.java
1daf371d 
  repository/src/main/java/org/apache/atlas/repository/migration/DataMigrationService.java
2fad333d 
  repository/src/test/java/org/apache/atlas/repository/migration/RelationshipMappingTest.java
0be4be8f 


Diff: https://reviews.apache.org/r/66534/diff/1/


Testing (updated)
-------

**Unit tests**
New tests added.

Build with tests.
Pre-commit build test.


Thanks,

Ashutosh Mestry


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message