atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 66478: ATLAS-2534: Atlas glossary support
Date Sat, 07 Apr 2018 00:14:05 GMT


> On April 6, 2018, 5:49 p.m., Sarath Subramanian wrote:
> > intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermCategorizationId.java
> > Lines 26 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993333#file1993333line26>
> >
> >     This class looks like a possible duplicate of AtlasRelatedCategoryId. Can't
we reuse the same pojo?

The idea behind these id classes (more like entity header class) is to hide the internals
of Atlas (relations etc) and model all Glossary related concepts as first class POJOs.


> On April 6, 2018, 5:49 p.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
> > Lines 396 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993337#file1993337line396>
> >
> >     this delete relies on atlas.DeleteHandlerV1.impl for soft/hard delete. Shouldn't
removal of glossary, terms, categories be always hard delete?

For now there's no way to enforce a hard delete for the glossary related entities. We can
track this in another JIRA where the internal type deletion will always be hard delete, whereas
the other ones can use the configured delete handler.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66478/#review200657
-----------------------------------------------------------


On April 5, 2018, 11:57 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66478/
> -----------------------------------------------------------
> 
> (Updated April 5, 2018, 11:57 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2534
>     https://issues.apache.org/jira/browse/ATLAS-2534
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Glossary implementation, no UI
> 
> 
> Diffs
> -----
> 
>   addons/models/0000-Area0/0010-base_model.json aebe955db 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
7bdbeabf0 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java
75665592e 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java
96b9705fa 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/expr/OrderByPredicate.java
PRE-CREATION 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
6820a93c2 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java
d3c976df5 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java
2903ae228 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 997ac68fb 
>   intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 688f6f4d2 
>   intg/src/main/java/org/apache/atlas/model/annotation/AtlasJSON.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermAssignmentStatus.java
PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermRelationshipStatus.java
PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryId.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryId.java
PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java
PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentId.java
PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermCategorizationId.java
PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 395431922 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 576847f6e

>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 61168f63f 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java PRE-CREATION

>   repository/src/main/java/org/apache/atlas/repository/ogm/AbstractDataTransferObject.java
f1a8bc91d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java a1a8f598d

>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasUserProfileDTO.java bcf2b9d27

>   repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java 818960d96

>   repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java c99d2f836

>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java
b9945d4fc 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
13ee2a6df 
>   repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java
a428b92ee 
>   repository/src/test/java/org/apache/atlas/TestModules.java c901e891c 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java PRE-CREATION

>   repository/src/test/java/org/apache/atlas/glossary/PaginationHelperTest.java PRE-CREATION

>   repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java
d8e916d77 
>   repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java
8e19f79e8 
>   webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
01a95cf80 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66478/diff/4/
> 
> 
> Testing
> -------
> 
> Added test GlossaryServiceTest, runs successfully.
> 
> mvn clean package executes successfully.
> 
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/235/
(in-progress)
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message