From dev-return-22049-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Fri Mar 30 11:47:52 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C0C1F180647 for ; Fri, 30 Mar 2018 11:47:51 +0200 (CEST) Received: (qmail 31370 invoked by uid 500); 30 Mar 2018 09:47:50 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 31355 invoked by uid 99); 30 Mar 2018 09:47:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Mar 2018 09:47:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C88851A0F2E for ; Fri, 30 Mar 2018 09:47:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.69 X-Spam-Level: X-Spam-Status: No, score=0.69 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id W8PV5KMjQYnb for ; Fri, 30 Mar 2018 09:47:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 64CD65F18F for ; Fri, 30 Mar 2018 09:47:47 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E3DF9E00C9; Fri, 30 Mar 2018 09:47:46 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 891DCC40A81; Fri, 30 Mar 2018 09:47:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2238178164988527149==" MIME-Version: 1.0 Subject: Re: Review Request 66374: ATLAS-2526: misc model updates From: David Radley To: Madhan Neethiraj , atlas , David Radley Date: Fri, 30 Mar 2018 09:47:46 -0000 Message-ID: <20180330094746.51821.55711@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: David Radley X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66374/ X-Sender: David Radley References: <20180330081621.51822.90538@reviews-vm2.apache.org> In-Reply-To: <20180330081621.51822.90538@reviews-vm2.apache.org> Reply-To: David Radley X-ReviewRequest-Repository: atlas --===============2238178164988527149== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66374/#review200231 ----------------------------------------------------------- addons/models/0000-Area0/0010-base_model.json Line 205 (original), 205 (patched) I suggest there may be migration implications to renaming these base types. I suggest versioning this change. addons/models/0300-Area3-SubjectArea/0310-Glossary.json Lines 89 (patched) I thought that we were thinking of these constraints as legacy and had assumed that we would not be adding any new ones. Doesn't the owned constraint imply that this is a one directional relationship, but the relationship definition is bidirectional. What does it mean that there is an attribute that uses the contraint but is not marked as legacy? I am wondering what we gain by adding the attribute in this way? addons/models/0300-Area3-SubjectArea/0320-CategoryHierarchy.json Lines 32 (patched) I wonder why we are adding legacy attributes. I can see it gives us a manditory parent; I thought the relationship design was such that we were dropping this capability. - David Radley On March 30, 2018, 8:16 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66374/ > ----------------------------------------------------------- > > (Updated March 30, 2018, 8:16 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2526 > https://issues.apache.org/jira/browse/ATLAS-2526 > > > Repository: atlas > > > Description > ------- > > - fixed incorrect syntax/braces in 0120-Collections.json that resulted in relationshipDefs not to be loaded > - renamed sourceToProcesses as inputToProcess and sinkFromProcesses as outputFromProcess > - added terms and categories as direct attributes of Glossary > - added anchor, parentCategory and childrenCategories as direct attributes of GlossaryCategory > - added anchor as direct attribute of GlossaryTerm > > > Diffs > ----- > > addons/models/0000-Area0/0010-base_model.json aebe955d > addons/models/0100-Area1-Collaboration/0120-Collections.json 4dbd2adb > addons/models/0300-Area3-SubjectArea/0310-Glossary.json cac2ce2a > addons/models/0300-Area3-SubjectArea/0320-CategoryHierarchy.json 10637970 > addons/models/0300-Area3-SubjectArea/0330-Terms.json f492ddfd > > > Diff: https://reviews.apache.org/r/66374/diff/1/ > > > Testing > ------- > > Verified Atlas server starts up successfully with updated models > > > Thanks, > > Madhan Neethiraj > > --===============2238178164988527149==--