From dev-return-22018-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Thu Mar 29 17:08:41 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B7CFB180645 for ; Thu, 29 Mar 2018 17:08:40 +0200 (CEST) Received: (qmail 69523 invoked by uid 500); 29 Mar 2018 15:08:39 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 69507 invoked by uid 99); 29 Mar 2018 15:08:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Mar 2018 15:08:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A77C6C0440; Thu, 29 Mar 2018 15:08:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.941 X-Spam-Level: X-Spam-Status: No, score=0.941 tagged_above=-999 required=6.31 tests=[FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id bo9lRr2ep4f4; Thu, 29 Mar 2018 15:08:36 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 06E6B5F173; Thu, 29 Mar 2018 15:08:36 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5CD51E0056; Thu, 29 Mar 2018 15:08:35 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0E8F9C40416; Thu, 29 Mar 2018 15:08:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6788976321431116244==" MIME-Version: 1.0 Subject: Re: Review Request 65435: ATLAS-2298 - Review of OCF Database Connector_New From: Yao Li To: Mandy Chessell Cc: Yao Li , atlas , David Radley Date: Thu, 29 Mar 2018 15:08:34 -0000 Message-ID: <20180329150834.17038.69542@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Yao Li X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65435/ X-Sender: Yao Li References: <20180329143342.17038.19526@reviews-vm2.apache.org> In-Reply-To: <20180329143342.17038.19526@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/OCFDatabaseConnectorErrorCode.java X-ReviewBoard-Diff-For: ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/OCFDatabaseConnection.java X-ReviewBoard-Diff-For: ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/OCFDatabaseConnector.java X-ReviewBoard-Diff-For: ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/util/PropertiesHelper.java X-ReviewBoard-Diff-For: ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/OCFDatabaseConnectorRuntimeException.java X-ReviewBoard-Diff-For: ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/DatabaseConnectCheckedException.java X-ReviewBoard-Diff-For: ocf-database-connector/pom.xml X-ReviewBoard-Diff-For: ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/OCFDatabaseCheckedExceptionBase.java X-ReviewBoard-Diff-For: ocf-database-connector/src/test/java/gaianocfconnector/GaianOCFConnectorTest.java X-ReviewBoard-Diff-For: ocf-database-connector/README.md X-ReviewBoard-Diff-For: ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/gaian/GaianOCFConnector.java X-ReviewBoard-Diff-For: ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/gaian/GaianOCFConnectorProvider.java X-ReviewBoard-Diff-For: ocf-database-connector/src/test/java/gaianocfconnector/UseGaianOCFConnector.java X-ReviewBoard-Diff-For: ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/OCFDatabaseConnectorProviderBase.java X-ReviewBoard-Diff-For: ocf-database-connector/src/main/resources/gaian.properties Reply-To: Yao Li X-ReviewRequest-Repository: atlas --===============6788976321431116244== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65435/ ----------------------------------------------------------- (Updated March 29, 2018, 3:08 p.m.) Review request for atlas and Mandy Chessell. Repository: atlas Description ------- This is the new review request for ATLAS-2298 OCF Database Connector. The old review on [https://reviews.apache.org/r/65123/](https://reviews.apache.org/r/65123/) will not be updated anymore. The OCF Database Connector is the subclass of OCF Connector and it is designed especially for connection to database to retrieve data. Here we implement a connector for Gaian (GaianOCFConnector) as an example for using OCF Database Connector. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298 Diffs (updated) ----- ocf-database-connector/README.md PRE-CREATION ocf-database-connector/pom.xml PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/OCFDatabaseConnection.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/OCFDatabaseConnector.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/OCFDatabaseConnectorProviderBase.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/gaian/GaianOCFConnector.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/gaian/GaianOCFConnectorProvider.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/DatabaseConnectCheckedException.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/OCFDatabaseCheckedExceptionBase.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/OCFDatabaseConnectorErrorCode.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/OCFDatabaseConnectorRuntimeException.java PRE-CREATION ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/util/PropertiesHelper.java PRE-CREATION ocf-database-connector/src/main/resources/gaian.properties PRE-CREATION ocf-database-connector/src/test/java/gaianocfconnector/GaianOCFConnectorTest.java PRE-CREATION ocf-database-connector/src/test/java/gaianocfconnector/UseGaianOCFConnector.java PRE-CREATION pom.xml ee2746a905f84359d426acfb1fa6d64c6310aaaf Diff: https://reviews.apache.org/r/65435/diff/4/ Changes: https://reviews.apache.org/r/65435/diff/3-4/ Testing ------- see test folder. Gaian has to set up in advance File Attachments ---------------- 0005-ATLAS-2298-05-Feb-code-review.patch https://reviews.apache.org/media/uploaded/files/2018/02/05/292c1917-9deb-4ced-8bd6-1689fc45fbd4__0005-ATLAS-2298-05-Feb-code-review.patch Thanks, Yao Li --===============6788976321431116244==--