atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 66203: [ATLAS-2510]: Add support to disable/enable propagated classification in entity
Date Tue, 27 Mar 2018 00:25:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66203/#review200006
-----------------------------------------------------------


Fix it, then Ship it!





intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java
Lines 85 (patched)
<https://reviews.apache.org/r/66203/#comment280591>

    Consider renaming 'disabledPropagatedClassifications' to 'propagationDisabledClassifications'


- Madhan Neethiraj


On March 26, 2018, 11:14 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66203/
> -----------------------------------------------------------
> 
> (Updated March 26, 2018, 11:14 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2510
>     https://issues.apache.org/jira/browse/ATLAS-2510
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Currently there is no way to remove propagated classification from an entity. This Jira
provides capability to disable/enable a propagated classification from an entity using REST.
> 
> The propagated classification name and its associated entity guid is supplied to the
REST to disable/enable right propagated classification.
> 
> 
> Disable a propagated tag:
> curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=true'
-H 'Authorization: Basic YWRtaW46YWRtaW4='
> 
> Enable a propagated tag:
> curl -X PUT 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=false'
-H 'Authorization: Basic YWRtaW46YWRtaW4='
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 605742dd 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 4a86670c 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 008314b3

>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java fce46da9 
>   repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java bfb5a711

>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
79e8e3e8 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
b5461d4b 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
19ac6209 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
c76f6405 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
8fe635ae 
>   repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 9b4c91d1

>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fdafa2c1 
> 
> 
> Diff: https://reviews.apache.org/r/66203/diff/5/
> 
> 
> Testing
> -------
> 
> Validated disable and enable of propagated classification through REST client - POSTMAN.
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/213/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message