atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 66226: ATLAS-2511:Provide options to selectively import database / tables from Hive into Atlas
Date Fri, 23 Mar 2018 15:50:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66226/#review199891
-----------------------------------------------------------




addons/hive-bridge/src/bin/import-hive.sh
Lines 34 (patched)
<https://reviews.apache.org/r/66226/#comment280398>

    This looks like a debug statement. Please review and remove/comment.



addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
Lines 94 (patched)
<https://reviews.apache.org/r/66226/#comment280399>

    "--tablename" ==> "--table" - to be consistent with flag "--database".



addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
Line 121 (original), 127 (patched)
<https://reviews.apache.org/r/66226/#comment280404>

    "tablename" ==> "table"



addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
Lines 172 (patched)
<https://reviews.apache.org/r/66226/#comment280401>

    "-n" ==> "-d"



addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
Lines 175 (patched)
<https://reviews.apache.org/r/66226/#comment280402>

    "-n" => "-d"
    "--namespace" ==> "--database"



addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
Lines 176 (patched)
<https://reviews.apache.org/r/66226/#comment280403>

    "Imports specified table within that database" ==> "Imports specific table in the given
database"



addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
Line 186 (original), 236 (patched)
<https://reviews.apache.org/r/66226/#comment280400>

    " && StringUtils.isEmpty(tableToImport)" - this condition shouldn't be added here.
Please review and update.


- Madhan Neethiraj


On March 22, 2018, 7:38 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66226/
> -----------------------------------------------------------
> 
> (Updated March 22, 2018, 7:38 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2511
>     https://issues.apache.org/jira/browse/ATLAS-2511
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-2511:Provide options to selectively import database / tables from Hive into Atlas
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/bin/import-hive.sh 47581ac 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
51df8d2 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java
271511e 
> 
> 
> Diff: https://reviews.apache.org/r/66226/diff/1/
> 
> 
> Testing
> -------
> 
> Tested in LOCAL VM
> 
> Usage 1: import-hive.sh [-n <database> OR --database <database>]
> Imports specified database and its tables ...
> 
> Usage 2: import-hive.sh [-n <database> OR --namespace <database>] [-t <table>
OR --table <table>]
> Imports specified table within that database ...
> 
> Usage 3: import-hive.sh
> Imports all databases and tables...
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message