atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 65999: ATLAS-2489: Lineage info to include relationship guid
Date Fri, 09 Mar 2018 23:55:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65999/#review198976
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java
Line 196 (original), 208 (patched)
<https://reviews.apache.org/r/65999/#comment279264>

    When will this 'if' be true? For an edge perhaps? If that is the case, we probably need
to process only the edges and discard the vertices in the result. Can you please review?


- Madhan Neethiraj


On March 9, 2018, 9:31 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65999/
> -----------------------------------------------------------
> 
> (Updated March 9, 2018, 9:31 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2489
>     https://issues.apache.org/jira/browse/ATLAS-2489
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java a2e1b5e8f 
>   repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java ec4125dab

> 
> 
> Diff: https://reviews.apache.org/r/65999/diff/1/
> 
> 
> Testing
> -------
> 
> PreCommit : https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/142/
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message