atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Radley <david...@apache.org>
Subject Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas
Date Mon, 05 Mar 2018 20:17:37 GMT


> On March 4, 2018, 11:07 a.m., David Radley wrote:
> > My review comments are from my initial look at the code; I hope to try running this
patch to verify it works for me
> 
> Pierre Padovani wrote:
>     I'll update the patch with the above changes today or tomorrow as I have time.
> 
> Pierre Padovani wrote:
>     I've updated the ATLAS-2470 with a new patch that should fix all of these issues.
> 
> Pierre Padovani wrote:
>     Hi David, I think I'm missing something. The instructions on the 'Using GIT with
Atlas' page are unclear on patch revisions. Do I create another review, or do I somehow update
this review?

It is best to use the same review for subsequent patches- so then it is possible to compare
between versions. I have updated the wiki with this information - thanks.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65885/#review198593
-----------------------------------------------------------


On March 2, 2018, 4:51 p.m., Pierre Padovani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65885/
> -----------------------------------------------------------
> 
> (Updated March 2, 2018, 4:51 p.m.)
> 
> 
> Review request for atlas and David Radley.
> 
> 
> Bugs: ATLAS-2470
>     https://issues.apache.org/jira/browse/ATLAS-2470
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This updates pom's to add the needed cassandra jars, and adds a dist profile embedded-cassandra-solr.
> 
> 
> Diffs
> -----
> 
>   distro/pom.xml 0103bef6 
>   distro/src/bin/atlas_config.py e6415cf4 
>   distro/src/bin/atlas_start.py 39be6b7c 
>   distro/src/bin/atlas_stop.py 66edd904 
>   distro/src/conf/cassandra.yml PRE-CREATION 
>   distro/src/conf/zookeeper/log4j.properties PRE-CREATION 
>   distro/src/conf/zookeeper/zoo.cfg PRE-CREATION 
>   distro/src/main/assemblies/standalone-package.xml 1881082e 
>   docs/src/site/twiki/InstallationSteps.twiki 6b9f0313 
>   graphdb/janus/pom.xml 143b775f 
> 
> 
> Diff: https://reviews.apache.org/r/65885/diff/1/
> 
> 
> Testing
> -------
> 
> Full build with the new embedded-cassandra-solr, and testing to make sure Atlas comes
up and is functional.
> 
> Be aware that we have been running Cassandra backed JanusGraph for months with no issues.
> 
> 
> Thanks,
> 
> Pierre Padovani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message