From dev-return-21233-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Wed Feb 21 21:22:19 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 788C918061A for ; Wed, 21 Feb 2018 21:22:18 +0100 (CET) Received: (qmail 88394 invoked by uid 500); 21 Feb 2018 20:22:17 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 88375 invoked by uid 99); 21 Feb 2018 20:22:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Feb 2018 20:22:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6D79CC0529; Wed, 21 Feb 2018 20:22:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.892 X-Spam-Level: * X-Spam-Status: No, score=1.892 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 4BS-jvsmZcMJ; Wed, 21 Feb 2018 20:22:15 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4CD4A5F397; Wed, 21 Feb 2018 20:22:14 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9ECD0E0194; Wed, 21 Feb 2018 20:22:13 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 72EE5C40136; Wed, 21 Feb 2018 20:22:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0009860465967075536==" MIME-Version: 1.0 Subject: Review Request 65737: ATLAS-2443: Changes to handling DELETEs From: Apoorv Naik To: Madhan Neethiraj Cc: Apoorv Naik , atlas Date: Wed, 21 Feb 2018 20:22:13 -0000 Message-ID: <20180221202213.28022.77975@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Apoorv Naik X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65737/ X-Sender: Apoorv Naik Reply-To: Apoorv Naik X-ReviewRequest-Repository: atlas --===============0009860465967075536== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65737/ ----------------------------------------------------------- Review request for atlas and Madhan Neethiraj. Repository: atlas Description ------- With previous implementation the serializer code was updated to not serialize null values this led to a side-effect on the client side, when an attribute had to be explicitly set to null. The client would not serialize the null into the JSON and the server would not see any difference in the requested entity change hence it would skip setting the null. This changeset reverts the serialization changes and adds some special handling around the DELETEd entities in the notification layer Diffs ----- repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 153052560 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java ebce279d8 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java ad8ab8e4d repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java d3df4642f repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 6132cb062 server-api/src/main/java/org/apache/atlas/RequestContextV1.java 08aa9606a typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java d939a9b8a webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java 53acf5631 Diff: https://reviews.apache.org/r/65737/diff/1/ Testing ------- PreCommit is failing with same errors as on branch-0.8 https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/108/ Thanks, Apoorv Naik --===============0009860465967075536==--