From dev-return-20925-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Tue Feb 6 11:08:34 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 4FA7F180657 for ; Tue, 6 Feb 2018 11:08:34 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3F419160C45; Tue, 6 Feb 2018 10:08:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9310C160C3A for ; Tue, 6 Feb 2018 11:08:32 +0100 (CET) Received: (qmail 15726 invoked by uid 500); 6 Feb 2018 10:08:31 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 15714 invoked by uid 99); 6 Feb 2018 10:08:31 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Feb 2018 10:08:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 840AC18030A; Tue, 6 Feb 2018 10:08:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.939 X-Spam-Level: X-Spam-Status: No, score=0.939 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id a9pCW7gdFKsN; Tue, 6 Feb 2018 10:08:20 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 699985F11F; Tue, 6 Feb 2018 10:08:19 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C048CE0047; Tue, 6 Feb 2018 10:08:18 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id C233DC400F6; Tue, 6 Feb 2018 10:08:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5270500651846131102==" MIME-Version: 1.0 Subject: Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API. From: Daniela Otelea To: Madhan Neethiraj , David Radley Cc: Mandy Chessell , Yao Li , atlas , Daniela Otelea Date: Tue, 06 Feb 2018 10:08:16 -0000 Message-ID: <20180206100816.26815.96725@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Daniela Otelea X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63502/ X-Sender: Daniela Otelea References: <20180129095154.29696.47601@reviews-vm2.apache.org> In-Reply-To: <20180129095154.29696.47601@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ArrayPropertyValue.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/TypeErrorException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/RelationshipNotKnownException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSEventPublisher.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnector.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSInstanceHelper.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/OMRSCohortRegistry.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/RelationshipConflictException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipEndDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ExternalStandardMapping.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/OMRSLogicErrorException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/InvalidEntityException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/MapPropertyValue.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EntityDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSInstanceEvent.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/localrepository/OMRSLocalRepository.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSTypeDefEvent.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnectorProviderBase.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSRepositoryContentManager.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSConnectorProvider.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/PatchErrorException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/PropertyErrorException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventExchangeRule.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefCategory.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogRecordOriginator.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/v1/OMRSEventV1ErrorSection.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapper.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/OMRSCheckedExceptionBase.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSInstanceEventProcessor.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefPatchAction.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSEvent.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefManager.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditCode.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyCategory.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classification.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSMetadataCollectionProvider.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTRepositoryConnectorProvider.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProvenanceType.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/CohortConnectionStatus.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProperties.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditingComponent.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefHelper.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/PagingErrorException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditLog.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/EntityNotKnownException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSTypeDefEventErrorCode.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetail.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefElementHeader.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSTypeDefEventProcessor.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EnumPropertyValue.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStoreConnectorBase.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSEventOriginator.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/TypeDefConflictException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollectionBase.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditLogRecordSeverity.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ClassificationOrigin.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDefCategory.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/SequencingOrder.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceElementHeader.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapperBase.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/OMRSConfigErrorException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSInstanceValidator.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/NotImplementedRuntimeException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/RelationshipKnownException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogRecord.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSEventErrorCode.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapperProviderBase.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSConnectionConsumer.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/EntityNotDeletedException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTMetadataCollection.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSRepositoryHelper.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/ClassificationNotKnownException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeCardinality.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSConnection.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefPatch.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/file/FileBasedAuditLogStoreConnector.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/MatchCriteria.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopic.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSRegistryEventType.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityProxy.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/TypeDefKnownException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefSummary.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSRepositoryConnector.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/OMRSCohortRegistryStoreConnectorBase.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTRepositoryConnector.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSRegistryEventProcessor.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/InvalidRelationshipException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/properties/MemberRegistration.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityUniverse.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/OMRSMetadataHighwayManager.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/PrimitivePropertyValue.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/v1/OMRSEventV1TypeDefSection.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/kafka/KafkaOMRSTopicProvider.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStoreProviderBase.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/TypeDefInUseException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/StructPropertyValue.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSInstanceRetrievalEventProcessor.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java X-ReviewBoard-Diff-For: omrs/README.md X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopicListener.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventProcessor.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/InvalidTypeDefException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventManager.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyValue.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationPropagationRule.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStore.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/file/FileBasedRegistryStoreConnector.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSInstanceEventProcessor.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/RepositoryErrorException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/file/FileBasedRegistryStoreProvider.java X-ReviewBoard-Diff-For: omrs/pom.xml X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSConnectorManager.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/README.md X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSConnectorProvider.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/file/FileBasedAuditLogStoreProvider.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceStatus.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSInstanceEventErrorCode.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/kafka/KafkaOMRSTopicConnector.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSRegistryEvent.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/HomeEntityException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSInstanceEventType.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/EntityConflictException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSEventListener.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/OMRSCohortManager.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/v1/OMRSEventV1InstanceSection.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefProperties.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSConnectorProperties.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumElementDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/OMRSRuntimeException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSRepositoryValidator.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSEventDirection.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/HomeRelationshipException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/StatusNotSupportedException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/OMRSCohortRegistryStoreProviderBase.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogReportingComponent.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceType.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceHeader.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/properties/CohortMembership.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSConnectorConsumer.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefValidator.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/RelationshipNotDeletedException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSRepositoryConnector.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSEventCategory.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeTypeDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/v1/OMRSEventV1RegistrySection.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/TypeDefNotKnownException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopicConnector.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSRegistryEventErrorCode.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSErrorCode.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/v1/OMRSEventV1.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSTypeDefEventType.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/OMRSCohortRegistryStore.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java Reply-To: Daniela Otelea X-ReviewRequest-Repository: atlas --===============5270500651846131102== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review196879 ----------------------------------------------------------- omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java Lines 71 (patched) It may be better to use interfaces over concrete types for good encapsulation and for loose coupling. I suggest to have "private List<>" instead of "private ArrayList<>". - Daniela Otelea On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63502/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2018, 9:51 a.m.) > > > Review request for atlas, David Radley and Madhan Neethiraj. > > > Repository: atlas > > > Description > ------- > > This is a request for code review of the OMRS. There are still parts of the code not written - the aim of the review is to make the connector interfaces available so they can be evaluated by teams buinding components against the APIs. > > There is a patch connected to https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the code plus other code that is not ready for review. The OMRS Connector API depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095. > > > Diffs > ----- > > omrs/README.md PRE-CREATION > omrs/pom.xml PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditCode.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditLog.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditLogRecordSeverity.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditingComponent.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogRecord.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogRecordOriginator.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogReportingComponent.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStore.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStoreConnectorBase.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStoreProviderBase.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/file/FileBasedAuditLogStoreConnector.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/file/FileBasedAuditLogStoreProvider.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSConnectionConsumer.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSConnectorConsumer.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSConnectorManager.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSConnectorProperties.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSConnectorProvider.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSRepositoryConnector.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSEventListener.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSEventPublisher.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventExchangeRule.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventManager.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventProcessor.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSEvent.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSEventCategory.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSEventDirection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSEventErrorCode.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSEventOriginator.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSInstanceEvent.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSInstanceEventErrorCode.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSInstanceEventProcessor.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSInstanceEventType.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSRegistryEvent.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSRegistryEventErrorCode.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSRegistryEventProcessor.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSRegistryEventType.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSTypeDefEvent.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSTypeDefEventErrorCode.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSTypeDefEventProcessor.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/OMRSTypeDefEventType.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/v1/OMRSEventV1.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/v1/OMRSEventV1ErrorSection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/v1/OMRSEventV1InstanceSection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/v1/OMRSEventV1RegistrySection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/events/v1/OMRSEventV1TypeDefSection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapper.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapperBase.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapperProviderBase.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSErrorCode.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/README.md PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/ClassificationNotKnownException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/EntityConflictException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/EntityNotDeletedException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/EntityNotKnownException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/HomeEntityException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/HomeRelationshipException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/InvalidEntityException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/InvalidRelationshipException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/InvalidTypeDefException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/NotImplementedRuntimeException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/OMRSCheckedExceptionBase.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/OMRSConfigErrorException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/OMRSLogicErrorException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/OMRSRuntimeException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/PagingErrorException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/PatchErrorException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/PropertyErrorException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/RelationshipConflictException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/RelationshipKnownException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/RelationshipNotDeletedException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/RelationshipNotKnownException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/RepositoryErrorException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/StatusNotSupportedException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/TypeDefConflictException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/TypeDefInUseException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/TypeDefKnownException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/TypeDefNotKnownException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/exception/TypeErrorException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/localrepository/OMRSLocalRepository.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSConnectorProvider.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSInstanceEventProcessor.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSRepositoryConnector.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSInstanceHelper.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSInstanceRetrievalEventProcessor.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSInstanceValidator.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSRepositoryContentManager.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSRepositoryHelper.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSRepositoryValidator.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefHelper.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefManager.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefValidator.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollectionBase.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/MatchCriteria.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/SequencingOrder.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ArrayPropertyValue.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classification.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ClassificationOrigin.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetail.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityProxy.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityUniverse.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EnumPropertyValue.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceElementHeader.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceHeader.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProperties.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyCategory.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyValue.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProvenanceType.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceStatus.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceType.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/MapPropertyValue.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/PrimitivePropertyValue.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/StructPropertyValue.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeCardinality.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeTypeDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationPropagationRule.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDefCategory.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EntityDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumElementDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ExternalStandardMapping.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipEndDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefCategory.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefElementHeader.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefPatch.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefPatchAction.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefProperties.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefSummary.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSConnection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSMetadataCollectionProvider.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnector.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnectorProviderBase.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/CohortConnectionStatus.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/OMRSCohortManager.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/OMRSMetadataHighwayManager.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/OMRSCohortRegistry.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/OMRSCohortRegistryStore.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/OMRSCohortRegistryStoreConnectorBase.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/OMRSCohortRegistryStoreProviderBase.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/file/FileBasedRegistryStoreConnector.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/file/FileBasedRegistryStoreProvider.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/properties/CohortMembership.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/properties/MemberRegistration.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTMetadataCollection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTRepositoryConnector.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTRepositoryConnectorProvider.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopic.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopicConnector.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopicListener.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/kafka/KafkaOMRSTopicConnector.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/kafka/KafkaOMRSTopicProvider.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/63502/diff/4/ > > > Testing > ------- > > There are samples of OMRS Connectors (without the metadata collection implementations). > > > File Attachments > ---------------- > > 0002-ATLAS-2246-26th-Jan-Code-Drop-of-OMRS.patch > https://reviews.apache.org/media/uploaded/files/2018/01/26/55450755-e990-48bc-bb96-d9b844c0ad0a__0002-ATLAS-2246-26th-Jan-Code-Drop-of-OMRS.patch > > > Thanks, > > Mandy Chessell > > --===============5270500651846131102==--