atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nixon Rodrigues <nixon.rodrig...@freestoneinfotech.com>
Subject Re: Review Request 65708: ATLAS-2451 : UI support to list tables in a namespace similar to listing tables in a db in the detailsPage of hive_db entity.
Date Mon, 19 Feb 2018 11:09:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65708/#review197745
-----------------------------------------------------------




dashboardv2/public/js/views/search/SearchResultLayoutView.js
Line 189 (original), 189 (patched)
<https://reviews.apache.org/r/65708/#comment278001>

    Default Error message "Invalid expression" is little ambiguous and it feels that some
query syntax is wrong.
    Rather message should be some what "Error on Server", which will give hint to the user
to check server errors.


- Nixon Rodrigues


On Feb. 19, 2018, 9:50 a.m., pratik pandey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65708/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2018, 9:50 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2451
>     https://issues.apache.org/jira/browse/ATLAS-2451
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Following API fetches the HBase tables in a namespace.
> 
> /api/atlas/v2/search/relationship?limit=25&offset=0&guid=<namespace_guid>&relation=__hbase_table.namespace
> 
> UI support could be added to list the hbase_table entities in the hbase_namespace entity's
detailsPage.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js ab74c3e 
>   dashboardv2/public/js/views/profile/ProfileLayoutView.js 79cf3a5 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js 18fb718 
> 
> 
> Diff: https://reviews.apache.org/r/65708/diff/1/
> 
> 
> Testing
> -------
> 
> Done one round of sanity testing.
> 
> 
> Thanks,
> 
> pratik pandey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message