atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 65646: ATLAS-2443: Include unique attributes in outgoing delete-notifications
Date Fri, 16 Feb 2018 23:12:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65646/
-----------------------------------------------------------

(Updated Feb. 16, 2018, 11:12 p.m.)


Review request for atlas and Madhan Neethiraj.


Changes
-------

Updated DeleteHandler, setNull handling for Enum and getValueMap behavior change


Bugs: ATLAS-2443
    https://issues.apache.org/jira/browse/ATLAS-2443


Repository: atlas


Description
-------

See ATLAS-2443


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java f0fef1f09

  repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
00fc57fbd 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java
ffcca053b 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
d4fdc2574 
  server-api/src/main/java/org/apache/atlas/RequestContext.java 3e729b52b 
  typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 766d2d0cd



Diff: https://reviews.apache.org/r/65646/diff/2/

Changes: https://reviews.apache.org/r/65646/diff/1-2/


Testing
-------

mvn clean package was successful and the change was verified by listening on the outgoing
topic ATLAS_ENTITIES

{"msgSourceIP":"127.0.0.1","msgCreatedBy":"","msgCreationTime":1510218830024,"message":{"entity":{"jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Reference","id":{"jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id","id":"e6997658-a702-4a58-87b3-05d7a7be1f34","version":0,"typeName":"hive_db","state":"ACTIVE"},"typeName":"hive_db","values":{"name":"default-test","location":"hdfs://localhost.localdomain:8020/apps/hive/warehouse","description":"Default
test Hive database","ownerType":{"value":"ROLE","ordinal":2},"qualifiedName":"default-test@cl1","owner":"public-test","clusterName":"cl1"},"traitNames":[],"traits":{},"systemAttributes":{}},"operationType":"ENTITY_CREATE","traits":[]},"version":{"version":"1.0.0"},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1}
{"msgSourceIP":"127.0.0.1","msgCreatedBy":"","msgCreationTime":1510218978333,"message":{"entity":{"jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Reference","id":{"jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id","id":"e6997658-a702-4a58-87b3-05d7a7be1f34","version":0,"typeName":"hive_db","state":"ACTIVE"},"typeName":"hive_db","values":{"qualifiedName":"default-test@cl1"},"traitNames":[],"traits":{},"systemAttributes":{}},"operationType":"ENTITY_DELETE","traits":[]},"version":{"version":"1.0.0"},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1}


Thanks,

Apoorv Naik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message