From dev-return-20818-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Mon Jan 29 18:56:28 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 67676180654 for ; Mon, 29 Jan 2018 18:56:28 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5721B160C31; Mon, 29 Jan 2018 17:56:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A6DDE160C2F for ; Mon, 29 Jan 2018 18:56:27 +0100 (CET) Received: (qmail 52805 invoked by uid 500); 29 Jan 2018 17:56:26 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 51583 invoked by uid 99); 29 Jan 2018 17:56:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jan 2018 17:56:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 91FAA18043C; Mon, 29 Jan 2018 17:56:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.69 X-Spam-Level: X-Spam-Status: No, score=0.69 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id smUo5bw8g7cu; Mon, 29 Jan 2018 17:56:24 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 995025FC0C; Mon, 29 Jan 2018 17:56:23 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E0C07E0115; Mon, 29 Jan 2018 17:56:22 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B794CC40098; Mon, 29 Jan 2018 17:56:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5438965655575520781==" MIME-Version: 1.0 Subject: Re: Review Request 65381: ATLAS-2152 : UI: Atlas UI not able to load the saved search From: Madhan Neethiraj To: Sharmadha Sainath , keval bhatt , Madhan Neethiraj , Nixon Rodrigues , Ayub Pathan Cc: atlas , pratik pandey Date: Mon, 29 Jan 2018 17:56:22 -0000 Message-ID: <20180129175622.29449.11583@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Madhan Neethiraj X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65381/ X-Sender: Madhan Neethiraj X-ReviewBoard-ShipIt: 1 References: <20180129142150.29696.93505@reviews-vm2.apache.org> In-Reply-To: <20180129142150.29696.93505@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Madhan Neethiraj X-ReviewRequest-Repository: atlas --===============5438965655575520781== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65381/#review196442 ----------------------------------------------------------- Ship it! Ship It! - Madhan Neethiraj On Jan. 29, 2018, 2:21 p.m., pratik pandey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65381/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2018, 2:21 p.m.) > > > Review request for atlas, Ayub Pathan, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath. > > > Bugs: ATLAS-2152 > https://issues.apache.org/jira/browse/ATLAS-2152 > > > Repository: atlas > > > Description > ------- > > After saving the search query, Atlas UI unable to load the saved search. > > Below exception is observed on the browser console > > CommonViewFunction.js:487 Uncaught TypeError: Cannot read property 'toJSON' of undefined > at CommonViewFunction.js:487 > at Function.s.each.s.forEach (underscore-min.js:5) > at Object.g.generateUrlFromSaveSearchObject (CommonViewFunction.js:476) > at L.d.applyValue (SearchLayoutView.js:155) > at L.d.stateChange (SaveSearchItemView.js:60) > at HTMLLIElement.dispatch (jquery.min.js:3) > at HTMLLIElement.q.handle (jquery.min.js:3) > > > Diffs > ----- > > dashboardv2/public/css/scss/override.scss 605bcd5 > dashboardv2/public/js/utils/CommonViewFunction.js 6cba9c0 > dashboardv2/public/js/views/search/QueryBuilderView.js fdb3c22 > dashboardv2/public/js/views/search/SearchLayoutView.js 255cf74 > dashboardv2/public/js/views/search/SearchQueryView.js 2446d3d > > > Diff: https://reviews.apache.org/r/65381/diff/1/ > > > Testing > ------- > > Done one round of sanity testing > > > Thanks, > > pratik pandey > > --===============5438965655575520781==--