From dev-return-20505-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Tue Jan 16 13:16:38 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id D53E918065B for ; Tue, 16 Jan 2018 13:16:38 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C539A160C34; Tue, 16 Jan 2018 12:16:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 964D0160C26 for ; Tue, 16 Jan 2018 13:16:37 +0100 (CET) Received: (qmail 63654 invoked by uid 500); 16 Jan 2018 12:16:36 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 63643 invoked by uid 99); 16 Jan 2018 12:16:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jan 2018 12:16:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E5239CBB4F; Tue, 16 Jan 2018 12:16:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.79 X-Spam-Level: ** X-Spam-Status: No, score=2.79 tagged_above=-999 required=6.31 tests=[FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id rnjHtW6UzzHm; Tue, 16 Jan 2018 12:16:34 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 65A0F5FC1E; Tue, 16 Jan 2018 12:16:33 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AB96FE01D8; Tue, 16 Jan 2018 12:16:32 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 7574CC40A39; Tue, 16 Jan 2018 12:16:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0015140392554205302==" MIME-Version: 1.0 Subject: Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework From: Yao Li To: Madhan Neethiraj Cc: Mandy Chessell , Yao Li , atlas Date: Tue, 16 Jan 2018 12:16:28 -0000 Message-ID: <20180116121628.57313.78913@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Yao Li X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63503/ X-Sender: Yao Li References: <20180112131314.29151.25899@reviews-vm2.apache.org> In-Reply-To: <20180112131314.29151.25899@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/CommentType.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaAttribute.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Rating.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaElement.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/Connector.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnections.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Referenceable.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Ratings.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comments.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReference.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/VirtualConnection.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Meaning.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalReference.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQuery.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaAttributes.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/MapSchemaElement.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/README.md X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Notes.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/KeyPattern.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Meanings.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifiers.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certification.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyIteratorBase.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connections.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaLink.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReferences.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classifications.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comment.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementType.java X-ReviewBoard-Diff-For: om-fwk-ocf/README.md X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaType.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Licenses.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Locations.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Location.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/NoteLogs.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementOrigin.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotations.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQueries.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Likes.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classification.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Schema.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Lineage.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/License.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaLinks.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/PropertyBase.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalReferences.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/StarRating.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/PrimitiveSchemaElement.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certifications.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/InformalTags.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java X-ReviewBoard-Diff-For: om-fwk-ocf/pom.xml X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifier.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaType.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/PagingIterator.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Feedback.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Endpoint.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedAssetProperties.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotation.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Like.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedAsset.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedAssets.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/NoteLog.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Note.java X-ReviewBoard-Diff-For: om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaUsage.java Reply-To: Yao Li X-ReviewRequest-Repository: atlas --===============0015140392554205302== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195448 ----------------------------------------------------------- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java Lines 96 (patched) is that necessary to check whether assetProperties, classfications etc are null? - Yao Li On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63503/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 1:13 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Repository: atlas > > > Description > ------- > > This patch contains the open connector framework code. This code is located in the om-fwk-ocf component and is described in JIRA https://issues.apache.org/jira/browse/ATLAS-1095 > > I have added a new patch to the Jira with fixes from Yao's comments. Upgraded Maven to 352 and rebuilt/rerun tests. > > > Diffs > ----- > > om-fwk-ocf/README.md PRE-CREATION > om-fwk-ocf/pom.xml PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/Connector.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/README.md PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotation.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotations.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyIteratorBase.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certification.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certifications.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classification.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classifications.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comment.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/CommentType.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comments.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connections.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementOrigin.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementType.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnections.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Endpoint.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifier.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifiers.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalReference.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalReferences.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Feedback.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/InformalTags.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/KeyPattern.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/License.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Licenses.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Like.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Likes.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Lineage.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Location.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Locations.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/MapSchemaElement.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Meaning.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Meanings.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Note.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/NoteLog.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/NoteLogs.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Notes.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/PagingIterator.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/PrimitiveSchemaElement.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/PropertyBase.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Rating.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Ratings.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Referenceable.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedAsset.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedAssetProperties.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedAssets.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReference.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReferences.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaType.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaUsage.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Schema.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaAttribute.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaAttributes.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaElement.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQueries.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQuery.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaLink.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaLinks.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaType.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/StarRating.java PRE-CREATION > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/VirtualConnection.java PRE-CREATION > pom.xml c64b26e > > > Diff: https://reviews.apache.org/r/63503/diff/3/ > > > Testing > ------- > > Simple sniff test to create connectors. > > > File Attachments > ---------------- > > 0001-ATLAS-1095-initial-code-drop-for-OCF-with-fixes-from.patch > https://reviews.apache.org/media/uploaded/files/2017/11/10/ad9eae3c-bb68-4bdc-b6b9-62ba12f651a0__0001-ATLAS-1095-initial-code-drop-for-OCF-with-fixes-from.patch > > > Thanks, > > Mandy Chessell > > --===============0015140392554205302==--