atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sar...@apache.org>
Subject Re: Review Request 65373: ATLAS-2421: updated Atlas notificaiton module to support V2 data structures
Date Mon, 29 Jan 2018 18:46:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65373/#review196447
-----------------------------------------------------------


Fix it, then Ship it!





webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
Lines 461 (patched)
<https://reviews.apache.org/r/65373/#comment276101>

    shouldn't we use atlasEntityStore.updateByUniqueAttributes() for partialUpdates?


- Sarath Subramanian


On Jan. 28, 2018, 11 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65373/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2018, 11 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2421
>     https://issues.apache.org/jira/browse/ATLAS-2421
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Following new notificaiton types are added: ENTITY_CREATE_V2, ENTITY_FULL_UPDATE_V2,
ENTITY_PARTIAL_UPDATE_V2, ENTITY_DELETE_V2.
> 
> 
> Diffs
> -----
> 
>   addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
03e340c9 
>   addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java 0d2e8df2

>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 42003bcf 
>   intg/src/main/java/org/apache/atlas/model/notification/HookNotification.java 83e52d55

>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 7b77a736 
>   intg/src/main/java/org/apache/atlas/utils/AtlasJson.java adf0665d 
>   notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java
47f72c55 
>   notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java
cf691af1 
>   webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 456a7784

> 
> 
> Diff: https://reviews.apache.org/r/65373/diff/2/
> 
> 
> Testing
> -------
> 
> Added unit tests to validate SerDe for newly added notification types.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message