atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 65381: ATLAS-2152 : UI: Atlas UI not able to load the saved search
Date Mon, 29 Jan 2018 17:56:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65381/#review196442
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Jan. 29, 2018, 2:21 p.m., pratik pandey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65381/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2018, 2:21 p.m.)
> 
> 
> Review request for atlas, Ayub Pathan, keval bhatt, Madhan Neethiraj, Nixon Rodrigues,
and Sharmadha Sainath.
> 
> 
> Bugs: ATLAS-2152
>     https://issues.apache.org/jira/browse/ATLAS-2152
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> After saving the search query, Atlas UI unable to load the saved search.
> 
> Below exception is observed on the browser console
> 
> CommonViewFunction.js:487 Uncaught TypeError: Cannot read property 'toJSON' of undefined
>     at CommonViewFunction.js:487
>     at Function.s.each.s.forEach (underscore-min.js:5)
>     at Object.g.generateUrlFromSaveSearchObject (CommonViewFunction.js:476)
>     at L.d.applyValue (SearchLayoutView.js:155)
>     at L.d.stateChange (SaveSearchItemView.js:60)
>     at HTMLLIElement.dispatch (jquery.min.js:3)
>     at HTMLLIElement.q.handle (jquery.min.js:3)
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/css/scss/override.scss 605bcd5 
>   dashboardv2/public/js/utils/CommonViewFunction.js 6cba9c0 
>   dashboardv2/public/js/views/search/QueryBuilderView.js fdb3c22 
>   dashboardv2/public/js/views/search/SearchLayoutView.js 255cf74 
>   dashboardv2/public/js/views/search/SearchQueryView.js 2446d3d 
> 
> 
> Diff: https://reviews.apache.org/r/65381/diff/1/
> 
> 
> Testing
> -------
> 
> Done one round of sanity testing
> 
> 
> Thanks,
> 
> pratik pandey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message