atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yao Li <bertha...@126.com>
Subject Re: Review Request 65123: ATLAS-2298 - Review of OCF Database Connector
Date Mon, 29 Jan 2018 15:45:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/
-----------------------------------------------------------

(Updated Jan. 29, 2018, 3:45 p.m.)


Review request for atlas and Mandy Chessell.


Changes
-------

update the correct patch


Repository: atlas


Description
-------

The OCF Database Connector is the subclass of OCF Connector and it is designed especially
for connection to database to retrieve data. 
Here we implement a connector for Gaian (GaianOCFConnector) as an example for using OCF Database
Connector. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298


Diffs (updated)
-----

  ocfdb/src/main/java/org/apache/atlas/ocf/Connector.java 89ebbba8 
  ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorBase.java cb0a9b5c 
  ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java a8691d6c 
  ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java 020b79c9 
  ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java f6b3bbc6 
  ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java 6313c244 
  ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java d45e944d 
  ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java bf0e2c27 
  ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java e6fad574 
  ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java 3d662717 
  ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java f78eba99 
  ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/README.md 40e4d123 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java 3af5a9ad 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Annotation.java fce22241 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java a6715941 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Annotations.java c9a4abb3 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java 405604c7 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java 4cedd13c 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java d1ca1593 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyIteratorBase.java a23b5df8

  ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java e8f45d4b 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java c9d5e69c 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Certification.java 5bc6475d 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Certifications.java 59529236 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Classification.java 095ce274 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Classifications.java 663c6dc5 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Comment.java cb1b04d1 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/CommentType.java 6c071450 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Comments.java 1991ca8e 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java 909499e3

  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Connection.java 5f11e2c2 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Connections.java 8a0c910c 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java 7cf8c6ad 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java 9f5057f4 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java 19119d51 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementOrigin.java caf482c3 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementType.java c942d85f 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java 15f056ce 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnections.java 65b2265f 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Endpoint.java e072b893 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifier.java 4d86134e 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifiers.java a14113f2 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalReference.java 93706ad5 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalReferences.java f293433e 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Feedback.java 9e057840 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java bed68242 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/InformalTags.java 09e9f987 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/KeyPattern.java ce6dae17 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/License.java 2f29fe9c 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Licenses.java e651ffd6 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Like.java 49684974 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Likes.java 5783f897 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Lineage.java 704a86dc 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Location.java fed3cda8 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Locations.java a4584a91 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/MapSchemaElement.java cedb5046 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Meaning.java 47de9f9d 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Meanings.java ce053961 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Note.java 0a81cb6d 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/NoteLog.java 93ab414e 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/NoteLogs.java 81f07766 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Notes.java 392aad3b 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/PagingIterator.java b2bc1f6c 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/PrimitiveSchemaElement.java cd398704

  ocfdb/src/main/java/org/apache/atlas/ocf/properties/PropertyBase.java 124ac596 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Rating.java 12c1c511 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Ratings.java 0935ae9f 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Referenceable.java ff93c60f 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAsset.java 3d4ec3e3 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAssetProperties.java 2ed017e1

  ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAssets.java ba7a4d72 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReference.java 8da295d8

  ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReferences.java 35d503b2

  ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaType.java 0b71d463 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaUsage.java b106e16a 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/Schema.java d3ce1912 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaAttribute.java 0d9e91a2 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaAttributes.java dd570f8a 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaElement.java cd832fdd 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQueries.java d3f182aa

  ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQuery.java 5c2ac582

  ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaLink.java 1a3b8d97 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaLinks.java 77e597e3 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaType.java 8b11a44b 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/StarRating.java 68ba7818 
  ocfdb/src/main/java/org/apache/atlas/ocf/properties/VirtualConnection.java ed94deed 
  ocfdb/src/test/java/AB.java ac21ec5c 
  ocfdb/src/test/java/Parent.java 70115fac 
  ocfdb/src/test/java/testPagingIterator.java 4b77cf12 


Diff: https://reviews.apache.org/r/65123/diff/4/

Changes: https://reviews.apache.org/r/65123/diff/3-4/


Testing
-------

create an instance of the Connector and use getData() function. Gaian has to be set up in
advance.


File Attachments
----------------

ATLAS-2298-update-patch-based-on-reviews.patch
  https://reviews.apache.org/media/uploaded/files/2018/01/29/e228728b-3ac4-49a9-8b44-bb3ff2a04052__ATLAS-2298-update-patch-based-on-reviews.patch


Thanks,

Yao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message