atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 65102: ATLAS-2354: Handling of empty attributes when using select
Date Tue, 16 Jan 2018 02:43:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65102/
-----------------------------------------------------------

(Updated Jan. 16, 2018, 2:43 a.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.


Changes
-------

Rebased on latest master


Bugs: ATLAS-2354
    https://issues.apache.org/jira/browse/ATLAS-2354


Repository: atlas


Description
-------

If any select attribute is null/empty then the results won't show up

Know issue: DB select name,description

If any of the select attribute is null/empty then the gremlin query returns no result


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 9a213a32d 
  repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 95ba46171 
  repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java b7f6d3af0 
  repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java c44eea3bb 
  repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 5b394cb23



Diff: https://reviews.apache.org/r/65102/diff/2/

Changes: https://reviews.apache.org/r/65102/diff/1-2/


Testing
-------

GremlinComposerTest and DSLQueriesTest were successful


Thanks,

Apoorv Naik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message