atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry <ames...@hortonworks.com>
Subject Re: Review Request 65152: ATLAS-2363: Strict DSL parsing
Date Sun, 14 Jan 2018 21:17:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65152/#review195405
-----------------------------------------------------------


Ship it!




Ship It!

- Ashutosh Mestry


On Jan. 14, 2018, 4:06 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65152/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2018, 4:06 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2363
>     https://issues.apache.org/jira/browse/ATLAS-2363
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java ad3d4d225

>   repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 2e132d115

>   repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 8787c52bd

>   repository/src/test/java/org/apache/atlas/query/DSLParsingTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 36f0bf722

> 
> 
> Diff: https://reviews.apache.org/r/65152/diff/1/
> 
> 
> Testing
> -------
> 
> Added new test to check exceptions when bad queries are passed
> Existing tests executing successfully
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message