atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 65064: ATLAS-2326: Error code fixes
Date Wed, 10 Jan 2018 17:27:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65064/#review195144
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/AtlasErrorCode.java
Line 55 (original), 55 (patched)
<https://reviews.apache.org/r/65064/#comment274289>

    I would suggest to not change the error-code across releases; it will make it difficult
to troubleshoot. 
    
    The gaps in error-code assignments can be filled as new error-codes are added.


- Madhan Neethiraj


On Jan. 10, 2018, 7:26 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65064/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2018, 7:26 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2326
>     https://issues.apache.org/jira/browse/ATLAS-2326
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Entity resource for GET was translating the AtlasBaseException incorrectly.
> The AtlasErrorCode class has duplicate codes and wrong sequence number
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 0953725cc 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java e3a5b1f3e 
> 
> 
> Diff: https://reviews.apache.org/r/65064/diff/1/
> 
> 
> Testing
> -------
> 
> GET localhost:21000/api/atlas/entities/abcd-123124 gives 404 instead of 500
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message