atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nixon Rodrigues <nixon.rodrig...@freestoneinfotech.com>
Subject Re: Review Request 64535: ATLAS-2282 : Saved favorite search appears only on refresh after creation when there are 25+ favorite searches .
Date Tue, 12 Dec 2017 13:49:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64535/#review193538
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On Dec. 12, 2017, 12:02 p.m., pratik pandey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64535/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2017, 12:02 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2282
>     https://issues.apache.org/jira/browse/ATLAS-2282
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> 1. Created 24 basic favorite search .
> 2. Created 25th basic favorite search. Popup notification displayed that the search is
successfully created.Without any refresh , 25th favorite search appeared in the favorite search
list.
> 3. Created 26th basic favorite search. Popup notification displayed that the search is
successfully created.
> 4.But the favorite search list didn't display the 26th basic favorite search but only
the ld 25 searches,
> 5.On page refresh , the 26th favorite search was displayed.
> Thus , when more than 25 Basic/Advanced favorite searches (Basic and Advanced separately
25) are created , the newly created favorite search is displayed only on page refresh.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/utils/CommonViewFunction.js e35e9ee 
>   dashboardv2/public/js/views/search/SearchLayoutView.js 0b1e9b1 
>   dashboardv2/public/js/views/search/save/SaveSearchView.js e8db33e 
> 
> 
> Diff: https://reviews.apache.org/r/64535/diff/1/
> 
> 
> Testing
> -------
> 
> Done one round of sanity testing.
> 
> 
> Thanks,
> 
> pratik pandey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message