atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sar...@apache.org>
Subject Re: Review Request 64435: ATLAS-2301: fix for concurrent modification error while creating audit record
Date Fri, 08 Dec 2017 07:12:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64435/#review193227
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Dec. 7, 2017, 7:20 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64435/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2017, 7:20 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2301
>     https://issues.apache.org/jira/browse/ATLAS-2301
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> While purging entity attributes for audit record creation, the removal from map was done
while in the middle of iterating the map. This caused the 'concurrent modification' error.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/v1/model/instance/Struct.java 9f0be5fd 
>   repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java
47d4e1df 
>   webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java
4633de95 
> 
> 
> Diff: https://reviews.apache.org/r/64435/diff/1/
> 
> 
> Testing
> -------
> 
> Verified that audit record creation handles attribute purging correctly.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message