Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.apache.org
Content-Type: multipart/alternative;
 boundary="===============5493345333445517508=="
MIME-Version: 1.0
Subject: Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS
 Connector API.
From: David Radley <davidrad@apache.org>
To: Madhan Neethiraj <madhan@apache.org>, David Radley <davidrad@apache.org>
Cc: Mandy Chessell <mandy_chessell@uk.ibm.com>, Yao Li <bertha_22@126.com>,
 atlas <dev@atlas.incubator.apache.org>
Date: Wed, 29 Nov 2017 16:01:14 -0000
Message-ID: <20171129160114.35988.602@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: David Radley <noreply@reviews.apache.org>
References: <20171110134353.31649.27320@reviews-vm2.apache.org>
In-Reply-To: <20171110134353.31649.27320@reviews-vm2.apache.org>
Reply-To: David Radley <davidrad@apache.org>
archived-at: Wed, 29 Nov 2017 16:01:23 -0000

--===============5493345333445517508==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review192122
-----------------------------------------------------------


omrs/pom.xml
Lines 42 (patched)
<https://reviews.apache.org/r/63502/#comment270145>

    This project does not resolve for me - where do I get hold of this dependant project?


omrs/pom.xml
Lines 58 (patched)
<https://reviews.apache.org/r/63502/#comment270144>

    I knitted this module into the latest atlas pom and it will not build with this error.  
    [ERROR]   The project org.apache.atlas:omrs:1.0.0-SNAPSHOT (/Users/david/atlasJanus/omrs/pom.xml) has 1 error
    [ERROR]     'dependencies.dependency.version' for org.codehaus.jackson:jackson-jaxrs:jar must be a valid version but is '${codehaus.jackson.version}'. @ org.apache.atlas:omrs:[unknown-version], /Users/david/atlasJanus/omrs/pom.xml, line 60, column 22
    
    It looks like the patch needs to be updated to use the new Jackson version


- David Radley


On Nov. 10, 2017, 1:43 p.m., Mandy Chessell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2017, 1:43 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This is a request for review of the OMRS Connector API.  The files of interest are:
> 
>     omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/*
>     omrs/src/main/java/org/apache/atlas/omrs/connectors/*
>     omrs/src/main/java/org/apache/atlas/omrs/ffdc/*
> 
> There is a patch connected to https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the code plus other code that is not ready for review.  The OMRS Connector API depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -----
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnection.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnector.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectorBase.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectorProviderBase.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/connectors/igc/IGCOMRSConnector.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/connectors/igc/IGCOMRSConnectorProvider.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/connectors/igc/IGCOMRSMetadataCollection.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTConnector.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTConnectorProvider.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTMetadataCollection.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/ClassificationNotKnownException.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/EntityNotDeletedException.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/EntityNotKnownException.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/NotImplementedRuntimeException.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSCheckedExceptionBase.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSErrorCode.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSRuntimeException.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/PagingErrorException.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/PropertyErrorException.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/README.md PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotDeletedException.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotKnownException.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/RepositoryErrorException.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/StatusNotSupportedException.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeDefInUseException.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeDefNotKnownException.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeErrorException.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/MetadataCollection.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/MetadataCollectionBase.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/MatchCriteria.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/SequencingOrder.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ArrayPropertyValue.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classification.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classifications.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetail.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetails.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityProxy.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummaries.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityUniverse.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EnumPropertyValue.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceElementHeader.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceHeader.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceIterator.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProperties.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyCategory.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyValue.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProvenanceType.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceStatus.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceTypes.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/MapPropertyValue.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/PrimitivePropertyValue.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationships.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/StructPropertyValue.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeCardinality.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeDef.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeDefs.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeTypeDef.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationDef.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationDefs.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationPropagationRule.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDef.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDefCategory.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDefs.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EntityDef.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EntityDefs.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumDef.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumDefs.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumElementDef.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumElementDefs.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ExternalStandardMapping.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ExternalStandardMappings.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDef.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefs.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipDef.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipDefs.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipEndDef.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/StringIdentifiers.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/StructDef.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/StructDefs.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefCategory.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefElementHeader.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefGallery.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefProperties.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefs.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63502/diff/3/
> 
> 
> Testing
> -------
> 
> There are samples of OMRS Connectors (without the metadata collection implementations).
> 
> 
> File Attachments
> ----------------
> 
> 0002-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch
>   https://reviews.apache.org/media/uploaded/files/2017/11/10/f6618d2e-681e-4f04-bc06-35324a341474__0002-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch
> 
> 
> Thanks,
> 
> Mandy Chessell
> 
>


--===============5493345333445517508==--