Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 39C40200D3B for ; Fri, 10 Nov 2017 14:09:53 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 382A5160BF2; Fri, 10 Nov 2017 13:09:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B000F160BEE for ; Fri, 10 Nov 2017 14:09:51 +0100 (CET) Received: (qmail 99533 invoked by uid 500); 10 Nov 2017 13:09:50 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 99522 invoked by uid 99); 10 Nov 2017 13:09:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Nov 2017 13:09:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 99059D7DC3; Fri, 10 Nov 2017 13:09:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id nxRopLSJmsPz; Fri, 10 Nov 2017 13:09:42 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 65F0B5F3CC; Fri, 10 Nov 2017 13:09:42 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 06756E069F; Fri, 10 Nov 2017 13:09:42 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id F1C2BC40195; Fri, 10 Nov 2017 13:09:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5788847453982398013==" MIME-Version: 1.0 Subject: Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API. From: Mandy Chessell To: Madhan Neethiraj , David Radley Cc: Mandy Chessell , Nigel Jones , atlas , Yao Li Date: Fri, 10 Nov 2017 13:09:41 -0000 Message-ID: <20171110130941.31649.44402@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mandy Chessell X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63502/ X-Sender: Mandy Chessell References: <20171103090213.24300.12220@reviews-vm2.apache.org> In-Reply-To: <20171103090213.24300.12220@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ArrayPropertyValue.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/registry/ClusterRegistryConfigFile.java X-ReviewBoard-Diff-For: omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ffdc/ConnectedAssetErrorCode.java X-ReviewBoard-Diff-For: omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/properties/OMASRelatedAssetProperties.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java X-ReviewBoard-Diff-For: omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetNotReferenceableException.java X-ReviewBoard-Diff-For: omas-assetowner/pom.xml X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipEndDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ExternalStandardMapping.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumElementDefs.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/MapPropertyValue.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EntityDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumDefs.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/RepositoryErrorException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationPropagationRule.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EntityDefs.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefs.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetail.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTMetadataCollection.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyCategory.java X-ReviewBoard-Diff-For: omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetREST.java X-ReviewBoard-Diff-For: om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/README.md X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classification.java X-ReviewBoard-Diff-For: om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFRuntimeException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProvenanceType.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProperties.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/StringIdentifiers.java X-ReviewBoard-Diff-For: omas-assetconsumer/pom.xml X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/NotImplementedRuntimeException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceIterator.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceTypes.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectorProviderBase.java X-ReviewBoard-Diff-For: omas-connectedasset/pom.xml X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefElementHeader.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefs.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefGallery.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/registry/RemoteRegistrations.java X-ReviewBoard-Diff-For: om-fwk-gaf/pom.xml X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EnumPropertyValue.java X-ReviewBoard-Diff-For: om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFCheckedException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceElementHeader.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTConnector.java X-ReviewBoard-Diff-For: omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/ffdc/AssetOwnerErrorCode.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDefCategory.java X-ReviewBoard-Diff-For: omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/properties/OMASConnectedAssetProperties.java X-ReviewBoard-Diff-For: omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/UnknownConnectionURLException.java X-ReviewBoard-Diff-For: omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/client/ConnectedAsset.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java X-ReviewBoard-Diff-For: om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFErrorCode.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/registry/ClusterRegistry.java X-ReviewBoard-Diff-For: omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/ServerCapability.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipDefs.java X-ReviewBoard-Diff-For: omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Endpoints.java X-ReviewBoard-Diff-For: omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/UnknownConnectionGUIDException.java X-ReviewBoard-Diff-For: omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerErrorCode.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeCardinality.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/PagingErrorException.java X-ReviewBoard-Diff-For: omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ConnectedAssetInterface.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/connectors/enterprise/MetadataCollections.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/SequencingOrder.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/registry/RemoteConnections.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityProxy.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeDefs.java X-ReviewBoard-Diff-For: omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/properties/OMASRelatedAsset.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/registry/LocalRegistration.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityUniverse.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/registry/ClusterOMRSConnection.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/connectors/enterprise/EnterpriseOMRSConnectorProvider.java X-ReviewBoard-Diff-For: omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerRuntimeException.java X-ReviewBoard-Diff-For: omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerCheckedExceptionBase.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeDefNotKnownException.java X-ReviewBoard-Diff-For: omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Platform.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/StructPropertyValue.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java X-ReviewBoard-Diff-For: omrs/README.md X-ReviewBoard-Diff-For: omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/ServerCapabilities.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnector.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotDeletedException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyValue.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/MetadataCollection.java X-ReviewBoard-Diff-For: omas-connectedasset/README.md X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/connectors/enterprise/EnterpriseOMRSMetadataCollection.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/ClassificationNotKnownException.java X-ReviewBoard-Diff-For: omrs/pom.xml X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetails.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/README.md X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ExternalStandardMappings.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/registry/RemoteRegistration.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/PropertyErrorException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationships.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceStatus.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classifications.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeErrorException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/connectors/enterprise/EnterpriseOMRSConnector.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnection.java X-ReviewBoard-Diff-For: omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/README.md X-ReviewBoard-Diff-For: omas-assetconsumer/README.md X-ReviewBoard-Diff-For: omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ffdc/README.md X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/StructDefs.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/registry/SynchronizationSpecification.java X-ReviewBoard-Diff-For: omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Server.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumElementDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefProperties.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/StatusNotSupportedException.java X-ReviewBoard-Diff-For: omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ffdc/ConnectedAssetRuntimeException.java X-ReviewBoard-Diff-For: omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerREST.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/StructDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummaries.java X-ReviewBoard-Diff-For: omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationDefs.java X-ReviewBoard-Diff-For: omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/ConnectionNameAmbiguousException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTConnectorProvider.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceHeader.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSCheckedExceptionBase.java X-ReviewBoard-Diff-For: omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Host.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/EntityNotDeletedException.java X-ReviewBoard-Diff-For: omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/AssetConsumerInterface.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSRuntimeException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipDef.java X-ReviewBoard-Diff-For: omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Servers.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeTypeDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/PrimitivePropertyValue.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDefs.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectorBase.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSErrorCode.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/MatchCriteria.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/EntityNotKnownException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeDefInUseException.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefCategory.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeDef.java X-ReviewBoard-Diff-For: omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotKnownException.java Reply-To: Mandy Chessell X-ReviewRequest-Repository: atlas archived-at: Fri, 10 Nov 2017 13:09:53 -0000 --===============5788847453982398013== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 3, 2017, 9:02 a.m., Nigel Jones wrote: > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotDeletedException.java > > Lines 25 (patched) > > > > > > Minor/naming -- We have an exception TypeDefInUse -- this is a similar situation so wonder if it should be RelationshipInUse It is not appropiate to rename since the two exceptions describe very different cirumstances. The TypeDefInUseException means that the TypeDef can not be deleted because there are instances available. The RelationshipNotDeletedException means that the relaitonship can not be restored because it has not been deleted. - Mandy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review190017 ----------------------------------------------------------- On Nov. 2, 2017, 12:03 p.m., Mandy Chessell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63502/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2017, 12:03 p.m.) > > > Review request for atlas, David Radley and Madhan Neethiraj. > > > Repository: atlas > > > Description > ------- > > This is a request for review of the OMRS Connector API. The files of interest are: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/* > omrs/src/main/java/org/apache/atlas/omrs/connectors/* > omrs/src/main/java/org/apache/atlas/omrs/ffdc/* > > There is a patch connected to https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the code plus other code that is not ready for review. The OMRS Connector API depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095. > > There is some OMAS code in the patch that can be ignored. > > > Diffs > ----- > > om-fwk-gaf/pom.xml PRE-CREATION > om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFCheckedException.java PRE-CREATION > om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFErrorCode.java PRE-CREATION > om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFRuntimeException.java PRE-CREATION > om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/README.md PRE-CREATION > omas-assetconsumer/README.md PRE-CREATION > omas-assetconsumer/pom.xml PRE-CREATION > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/AssetConsumerInterface.java PRE-CREATION > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java PRE-CREATION > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerCheckedExceptionBase.java PRE-CREATION > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerErrorCode.java PRE-CREATION > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerRuntimeException.java PRE-CREATION > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetNotReferenceableException.java PRE-CREATION > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/ConnectionNameAmbiguousException.java PRE-CREATION > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/README.md PRE-CREATION > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/UnknownConnectionGUIDException.java PRE-CREATION > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/UnknownConnectionURLException.java PRE-CREATION > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerREST.java PRE-CREATION > omas-assetowner/pom.xml PRE-CREATION > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/ffdc/AssetOwnerErrorCode.java PRE-CREATION > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Endpoints.java PRE-CREATION > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Host.java PRE-CREATION > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Platform.java PRE-CREATION > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Server.java PRE-CREATION > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/ServerCapabilities.java PRE-CREATION > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/ServerCapability.java PRE-CREATION > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Servers.java PRE-CREATION > omas-connectedasset/README.md PRE-CREATION > omas-connectedasset/pom.xml PRE-CREATION > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ConnectedAssetInterface.java PRE-CREATION > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/client/ConnectedAsset.java PRE-CREATION > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ffdc/ConnectedAssetErrorCode.java PRE-CREATION > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ffdc/ConnectedAssetRuntimeException.java PRE-CREATION > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ffdc/README.md PRE-CREATION > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/properties/OMASConnectedAssetProperties.java PRE-CREATION > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/properties/OMASRelatedAsset.java PRE-CREATION > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/properties/OMASRelatedAssetProperties.java PRE-CREATION > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetREST.java PRE-CREATION > omrs/README.md PRE-CREATION > omrs/pom.xml PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnector.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectorBase.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectorProviderBase.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/connectors/enterprise/EnterpriseOMRSConnector.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/connectors/enterprise/EnterpriseOMRSConnectorProvider.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/connectors/enterprise/EnterpriseOMRSMetadataCollection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/connectors/enterprise/MetadataCollections.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTConnector.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTConnectorProvider.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTMetadataCollection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/ClassificationNotKnownException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/EntityNotDeletedException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/EntityNotKnownException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/NotImplementedRuntimeException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSCheckedExceptionBase.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSErrorCode.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSRuntimeException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/PagingErrorException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/PropertyErrorException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/README.md PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotDeletedException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotKnownException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/RepositoryErrorException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/StatusNotSupportedException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeDefInUseException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeDefNotKnownException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeErrorException.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/MetadataCollection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/MatchCriteria.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/SequencingOrder.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ArrayPropertyValue.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classification.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classifications.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetail.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetails.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityProxy.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummaries.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityUniverse.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EnumPropertyValue.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceElementHeader.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceHeader.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceIterator.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProperties.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyCategory.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyValue.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProvenanceType.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceStatus.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceTypes.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/MapPropertyValue.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/PrimitivePropertyValue.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationships.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/StructPropertyValue.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeCardinality.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeDefs.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeTypeDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationDefs.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationPropagationRule.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDefCategory.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDefs.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EntityDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EntityDefs.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumDefs.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumElementDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumElementDefs.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ExternalStandardMapping.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ExternalStandardMappings.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefs.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipDefs.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipEndDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/StringIdentifiers.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/StructDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/StructDefs.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefCategory.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefElementHeader.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefGallery.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefProperties.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefs.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/registry/ClusterOMRSConnection.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/registry/ClusterRegistry.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/registry/ClusterRegistryConfigFile.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/registry/LocalRegistration.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/registry/RemoteConnections.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/registry/RemoteRegistration.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/registry/RemoteRegistrations.java PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/registry/SynchronizationSpecification.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/63502/diff/1/ > > > Testing > ------- > > There are samples of OMRS Connectors (without the metadata collection implementations. I will do them once I have feedback on the basic API > > > Thanks, > > Mandy Chessell > > --===============5788847453982398013==--