Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 77440200D2F for ; Wed, 1 Nov 2017 16:44:48 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 75D17160BEA; Wed, 1 Nov 2017 15:44:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BB72D160BE6 for ; Wed, 1 Nov 2017 16:44:47 +0100 (CET) Received: (qmail 20375 invoked by uid 500); 1 Nov 2017 15:44:46 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 20364 invoked by uid 99); 1 Nov 2017 15:44:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Nov 2017 15:44:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D289B1A4075; Wed, 1 Nov 2017 15:44:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.5 X-Spam-Level: *** X-Spam-Status: No, score=3.5 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id lZ8SBxdlcnug; Wed, 1 Nov 2017 15:44:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 79B0161176; Wed, 1 Nov 2017 15:44:44 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E5345E00A3; Wed, 1 Nov 2017 15:44:43 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A8048C40096; Wed, 1 Nov 2017 15:44:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4244950840794684525==" MIME-Version: 1.0 Subject: Re: Review Request 63462: ATLAS-2245: Update maven dependency to 3.5.0 From: Nigel Jones To: Mandy Chessell , Apoorv Naik , Madhan Neethiraj , David Radley Cc: Nigel Jones , atlas Date: Wed, 01 Nov 2017 15:44:41 -0000 Message-ID: <20171101154441.32367.54663@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Nigel Jones X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63462/ X-Sender: Nigel Jones References: <20171101153744.28804.99120@reviews-vm2.apache.org> In-Reply-To: <20171101153744.28804.99120@reviews-vm2.apache.org> Reply-To: Nigel Jones X-ReviewRequest-Repository: atlas archived-at: Wed, 01 Nov 2017 15:44:48 -0000 --===============4244950840794684525== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63462/ ----------------------------------------------------------- (Updated Nov. 1, 2017, 3:44 p.m.) Review request for atlas, Apoorv Naik, David Radley, Madhan Neethiraj, and Mandy Chessell. Repository: atlas Description ------- ATLAS-2245: Update maven dependency to 3.5.0 Also updated Java Dependency to 8 Both are enforced in the top level POM using the maven enforcer plugin Initial implementation used the 'dependencies' tag in the pom. However this is deprecated, not inherited, and was primarily intended for plugins rather than projects. THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7. Many users will need to update maven in particular Diffs (updated) ----- pom.xml 5a6add64 Diff: https://reviews.apache.org/r/63462/diff/3/ Changes: https://reviews.apache.org/r/63462/diff/2-3/ Testing ------- Test with mvn clean install If Maven version is not 3.5.0: [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ apache-atlas --- [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion failed with message: ** Please upgrade maven to 3.5.2 or above. See https://maven.apache.org/install.html Similar for Java If dependencies met, build continues ok Proposed (in Jira) to update wiki page & send out email on dist list due to developer impact THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7. Many users will need to update maven in particular Thanks, Nigel Jones --===============4244950840794684525==--