atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Radley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ATLAS-2269) Errors in the Area 0 and 3 models shown up by the latest Jackson libraries
Date Tue, 21 Nov 2017 09:06:00 GMT

    [ https://issues.apache.org/jira/browse/ATLAS-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260445#comment-16260445
] 

David Radley commented on ATLAS-2269:
-------------------------------------

The symptoms of the older versions of the models was that the new Jackson libraries could
not deserlialise the json in the model files. I saw this when using 

ObjectMapper mapper = new ObjectMapper()
            .configure(DeserializationConfig.Feature.USE_BIG_DECIMAL_FOR_FLOATS, true);
to deserialise json.
then
   AtlasTypesDef typedDef = mapper.readValue(file, AtlasTypesDef.class);

This threw exceptions.
 
I have not seen errors in runtime Atlas - because I cannot start Atlas due to the current
state of the code. I suspect that reading the json files may produce errors. In my tests unrecoginised
content was causing errors. The unrecognised content highlighted mismatches between the json
model files and their equivalent Java classes. 
  
I also corrected a spelling mistake in the models of the word translated.

If applications had been written and relied on the old model files then those applications
would need to be rewritten. As the models are very new and only in master - I think this is
a low risk; so changing the model files without versioning them at this stage should be acceptable.
If we get feedback such that this approach is not acceptable we can make these changes in
new versions in patches. 
 

> Errors in the Area 0 and 3 models shown up by the latest Jackson libraries
> --------------------------------------------------------------------------
>
>                 Key: ATLAS-2269
>                 URL: https://issues.apache.org/jira/browse/ATLAS-2269
>             Project: Atlas
>          Issue Type: Bug
>            Reporter: David Radley
>            Assignee: David Radley
>             Fix For: 1.0.0
>
>         Attachments: ATLAS2269.patch
>
>
> while playing with serializing the models, I notice that the latest Jackson libraries
check json more strictly against the java class it is deserializing to. This has uncovered
some errors in the json models. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message