atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sar...@apache.org>
Subject Re: Review Request 64141: [ATLAS-2287]: Include lucene libraries when building atlas distribution with Janus profile
Date Thu, 30 Nov 2017 20:59:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64141/
-----------------------------------------------------------

(Updated Nov. 30, 2017, 12:59 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.


Changes
-------

addressed review comments


Bugs: ATLAS-2287
    https://issues.apache.org/jira/browse/ATLAS-2287


Repository: atlas


Description
-------

When Atlas is build using -Pdist profile, lucene jars are excluded during packaging of the
war file. Since we are not shading graphdb module for janus profile, these jars are needed
as run time dependency.
Titan's shaded jar includes the lucene libraries and hence were excluded during packaging
of war to avoid duplicate dependencies.


Diffs (updated)
-----

  distro/pom.xml eea256d8 
  graphdb/janus/src/test/resources/atlas-application.properties ebc74ff3 
  intg/src/test/resources/atlas-application.properties ce9351a6 
  pom.xml 3720c1f5 
  repository/pom.xml e24122e5 
  webapp/pom.xml b4a96d36 


Diff: https://reviews.apache.org/r/64141/diff/2/

Changes: https://reviews.apache.org/r/64141/diff/1-2/


Testing
-------

validated building atlas distribution using both janus and titan0 profile. Atlas starts fine
and basic functionalities working.

mvn clean install -DskipTests -Pdist,embedded-hbase-solr
mvn clean install -DskipTests -Pdist,embedded-hbase-solr -DGRAPH-PROVIDER=titan0


Thanks,

Sarath Subramanian


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message