atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pratik pandey <pratik2...@gmail.com>
Subject Re: Review Request 63408: ATLAS-2208 : Include historical entities in Schema tab checked by default for DELETED tables
Date Wed, 22 Nov 2017 12:57:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63408/
-----------------------------------------------------------

(Updated Nov. 22, 2017, 12:57 p.m.)


Review request for atlas, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS:2208
    https://issues.apache.org/jira/browse/ATLAS:2208


Repository: atlas


Description
-------

1. Created and dropped hive_table table1 with columns col1 , col2
2. Fired basic search hive_table and checked "Show historical entities" which listed the DELETED
table.
3. Clicked on the DELETED table and clicked on the Schema Tab for the table.
4. Include historical entities was checked by default (I suppose it is displaying the Show
historical entities value checked in the Search page ).
5. Though it is checked , no columns were listed.
6. Toggled the value twice. Now Include historical entities is checked again , and now DELETED
columns were listed.


Diffs (updated)
-----

  dashboardv2/gruntfile.js ba9ea0f 
  dashboardv2/package.json 957e916 
  dashboardv2/public/css/scss/override.scss 3d6f554 
  dashboardv2/public/css/scss/search.scss 26f1505 
  dashboardv2/public/js/main.js f6c0157 
  dashboardv2/public/js/utils/TableLayout.js a2ba0a6 
  dashboardv2/public/js/utils/Utils.js 47e9ac2 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js 2e8c165 


Diff: https://reviews.apache.org/r/63408/diff/2/

Changes: https://reviews.apache.org/r/63408/diff/1-2/


Testing
-------

Done one round of sanity testing.


Thanks,

pratik pandey


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message