atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Wallis <graham_wal...@uk.ibm.com>
Subject Re: Review Request 63909: ATLAS-2232 - Remove source and target directives now at java8
Date Tue, 21 Nov 2017 11:19:06 GMT


> On Nov. 17, 2017, 5:47 p.m., Madhan Neethiraj wrote:
> > After removal of source/target directives, "mvn package -DskipTests -DskipEnunciate=false"
fails with the following error (i.e. doesn't recognize Java 1.7+ syntax). I will have a review
shortly to add source/target directrives with 1.8 as version.
> > 
> > [WARNING] [ENUNCIATE] [javac] [ERROR] com.webcohesion.enunciate.Enunciate$URLFileObject[file:/Apache/git/atlas/webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java]:360:58
/Apache/git/atlas/webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java:360: error:
diamond operator is not supported in -source 1.5
> > [WARNING] [ENUNCIATE] [javac] /Apache/git/atlas/webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java:360:
error: diamond operator is not supported in -source 1.5
> > [WARNING] [ENUNCIATE] [javac]         List<AtlasClassification> ret    = new
ArrayList<>();
> > [WARNING] [ENUNCIATE] [javac]                                                  
       ^
> > [WARNING] [ENUNCIATE] [javac]   (use -source 7 or higher to enable diamond operator)
> 
> Graham Wallis wrote:
>     Interesting - what version of Java did you use when you did the build (the one that
failed)? When I did it with Java 1.8 it seemed OK.
> 
> Madhan Neethiraj wrote:
>     $ java -version
>     java version "1.8.0_121"
>     Java(TM) SE Runtime Environment (build 1.8.0_121-b13)
>     Java HotSpot(TM) 64-Bit Server VM (build 25.121-b13, mixed mode)

Thanks Madhan - I just re-ran my build and yes, I see exactly the same as you - not sure what
I did first time around! I suspect the problem is caused by a lack of maven compiler plugin
as the enunicate plugin apparently takes its defaults (for source, target) from the compiler
plugin. Better to specify them explicitly as you have done.


- Graham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63909/#review191366
-----------------------------------------------------------


On Nov. 17, 2017, 12:52 p.m., Graham Wallis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63909/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2017, 12:52 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-2232 - Remove source and target directives now at java8
> Only file affected is webapp/pom.xml
> 
> 
> Diffs
> -----
> 
>   webapp/pom.xml 569e06f8dfcbfc57d3e4a602e355f4ab0c7eea32 
> 
> 
> Diff: https://reviews.apache.org/r/63909/diff/1/
> 
> 
> Testing
> -------
> 
> Built with enunciate enabled and inspected API docs, which look fine.
> mvn clean
> mvn install -DskipTests
> mvn package -DskipTests -DskipEnunciate=false
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message