atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Wallis <graham_wal...@uk.ibm.com>
Subject Re: Review Request 63879: ATLAS-2262 Fix intermittent relationship failures
Date Mon, 20 Nov 2017 17:15:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63879/
-----------------------------------------------------------

(Updated Nov. 20, 2017, 5:15 p.m.)


Review request for atlas.


Repository: atlas


Description
-------

ATLAS-2262.patch
This patch contains fixes for the EntityGraphMapper and related classes, to fix intermittent
relationship failures.
This change means that an UPDATE operation will inspect the existing and new relationships
and compare them fully before adding/modifying edges. Matching elements will be reused, new
elements will be added, and redundant elements will be discarded. The behaviour should be
consistent regardless of which graph provider is being used.


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3e602431400677cbe0d8fe440732b02bb4a30a62

  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java
739d610263a1b5bb8a0a9ff8183196ebe2c6294b 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
b0f9845d6e92a6ef4bb53cccec537a0a54afb5e8 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AttributeMutationContext.java
b6d82dd834b8cc8b3bac630c084b91ac34dd0cec 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
f6a15b695e676bc035ce8336bcce7bacf1852ff9 
  repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java b24774d6376765f054022b9220b61769505e488c

  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
fd1b6db0c4dd57cd70ba56f49b9c4751f6915858 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java
d207a6958ab9dce0bd9f8e08c8e49232ab7d2e8a 


Diff: https://reviews.apache.org/r/63879/diff/3/

Changes: https://reviews.apache.org/r/63879/diff/2-3/


Testing
-------

Build with full tests with janus grap provider


Thanks,

Graham Wallis


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message