atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yao Li <bertha...@126.com>
Subject Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.
Date Mon, 20 Nov 2017 13:55:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review191507
-----------------------------------------------------------




omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/MetadataCollection.java
Lines 367 (patched)
<https://reviews.apache.org/r/63502/#comment269355>

    for functions findEntitiesBy* and searchForEntities, why do you return EntityDetails instead
of EntityUniverses(a list of EntityUniverse,this class does not exist in your patch now),
if you want to  return the entity includes Relationships, then EntityUniverse is necessary.
would you mind explaining this?


- Yao Li


On Nov. 10, 2017, 1:43 p.m., Mandy Chessell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2017, 1:43 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This is a request for review of the OMRS Connector API.  The files of interest are:
> 
>     omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/*
>     omrs/src/main/java/org/apache/atlas/omrs/connectors/*
>     omrs/src/main/java/org/apache/atlas/omrs/ffdc/*
> 
> There is a patch connected to https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246
that has the code plus other code that is not ready for review.  The OMRS Connector API depends
on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -----
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnection.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnector.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectorBase.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectorProviderBase.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/connectors/igc/IGCOMRSConnector.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/connectors/igc/IGCOMRSConnectorProvider.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/connectors/igc/IGCOMRSMetadataCollection.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTConnector.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTConnectorProvider.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTMetadataCollection.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/ClassificationNotKnownException.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/EntityNotDeletedException.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/EntityNotKnownException.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/NotImplementedRuntimeException.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSCheckedExceptionBase.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSErrorCode.java PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSRuntimeException.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/PagingErrorException.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/PropertyErrorException.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/README.md PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotDeletedException.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotKnownException.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/RepositoryErrorException.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/StatusNotSupportedException.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeDefInUseException.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeDefNotKnownException.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeErrorException.java PRE-CREATION

>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/MetadataCollection.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/MetadataCollectionBase.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/MatchCriteria.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/SequencingOrder.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ArrayPropertyValue.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classification.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classifications.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetail.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetails.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityProxy.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummaries.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityUniverse.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EnumPropertyValue.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceElementHeader.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceHeader.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceIterator.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProperties.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyCategory.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyValue.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProvenanceType.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceStatus.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceTypes.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/MapPropertyValue.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/PrimitivePropertyValue.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationships.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/StructPropertyValue.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeCardinality.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeDef.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeDefs.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeTypeDef.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationDef.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationDefs.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationPropagationRule.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDef.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDefCategory.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDefs.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EntityDef.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EntityDefs.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumDef.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumDefs.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumElementDef.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumElementDefs.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ExternalStandardMapping.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ExternalStandardMappings.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDef.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefs.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipDef.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipDefs.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipEndDef.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/StringIdentifiers.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/StructDef.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/StructDefs.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefCategory.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefElementHeader.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefGallery.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefProperties.java
PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefs.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63502/diff/3/
> 
> 
> Testing
> -------
> 
> There are samples of OMRS Connectors (without the metadata collection implementations).
> 
> 
> File Attachments
> ----------------
> 
> 0002-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch
>   https://reviews.apache.org/media/uploaded/files/2017/11/10/f6618d2e-681e-4f04-bc06-35324a341474__0002-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch
> 
> 
> Thanks,
> 
> Mandy Chessell
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message