atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 63934: [ATLAS-2267]: Update basic search to support classification attributes
Date Sat, 18 Nov 2017 02:11:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63934/#review191433
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Nov. 18, 2017, 12:26 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63934/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2017, 12:26 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2267
>     https://issues.apache.org/jira/browse/ATLAS-2267
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Basic search supports search on :
> Type Name (with attribute filters)
> Classification Name (with attribute filters)
> Full Text Search
> Support to search on all entities with any classifications is not present currently.
Also classification attributes are not retrieved in search results and there is a need to
provide a flag (includeClassificationAttributes) to toggle search results to include/exclude
classification attributes.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java f5a48130

>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 324946a9

>   repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
776f5bf5 
>   repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 40c66ddf

>   repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 91ee1a5c 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
1c9b8f18 
> 
> 
> Diff: https://reviews.apache.org/r/63934/diff/2/
> 
> 
> Testing
> -------
> 
> curl -X POST \
>   http://localhost:21000/api/atlas/v2/search/basic \
>   -H 'authorization: Basic YWRtaW46YWRtaW4=' \
>   -H 'content-type: application/json' \
>   -d '{
>   "excludeDeletedEntities": true,
>   "includeClassificationAttributes": true,
>   "entityFilters": null,
>   "tagFilters": null,
>   "attributes": null,
>   "limit": 100,
>   "offset": 0,
>   "typeName": null,
>   "classification": "*"
> }'
> 
> validated that all entities tagged by classification are returned in search result and
classification attributes are returned.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message