atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 63690: [ATLAS-2253]: Remove shading of janus graph-provider module
Date Thu, 09 Nov 2017 01:22:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63690/#review190526
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Nov. 9, 2017, 12:31 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63690/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2017, 12:31 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2253
>     https://issues.apache.org/jira/browse/ATLAS-2253
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> In atlas-graphdb-janus module, we build a shaded jar containing janus libraries and all
its dependent libraries. This is not needed as we don't shade any janus classes and use vanilla
janus libraries. We should package only atlas specific classes in the janus graph provider
jar. This will lighten the atlas-graphdb-janus.jar from 48MB to 69K and remove unnecessary
duplication of dependencies.
> 
> 
> Diffs
> -----
> 
>   graphdb/janus/pom.xml e8a0a611 
>   graphdb/titan0/pom.xml d1674a90 
>   graphdb/titan1/pom.xml 74596bdb 
>   pom.xml 5a6add64 
> 
> 
> Diff: https://reviews.apache.org/r/63690/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean package -DGRAPH-PROVIDER=janus suceeded in 20:04 min
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message