Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EEE24200D35 for ; Tue, 24 Oct 2017 03:11:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id ED64C160BF0; Tue, 24 Oct 2017 01:11:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 37A0D1609E0 for ; Tue, 24 Oct 2017 03:11:08 +0200 (CEST) Received: (qmail 17108 invoked by uid 500); 24 Oct 2017 01:11:07 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 17061 invoked by uid 99); 24 Oct 2017 01:11:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Oct 2017 01:11:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3740AC050B; Tue, 24 Oct 2017 01:11:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id o5wgnAgTkkXT; Tue, 24 Oct 2017 01:11:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id DC8AE5FC6A; Tue, 24 Oct 2017 01:11:04 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 352D6E045B; Tue, 24 Oct 2017 01:11:04 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0FE03C417AF; Tue, 24 Oct 2017 01:11:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8386617175335118280==" MIME-Version: 1.0 Subject: Re: Review Request 63136: ATLAS-2218: Separate UT and IT in webapp module From: Sarath Subramanian To: Ashutosh Mestry , Madhan Neethiraj , Sarath Subramanian Cc: Apoorv Naik , atlas Date: Tue, 24 Oct 2017 01:11:02 -0000 Message-ID: <20171024011102.11167.20384@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sarath Subramanian X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63136/ X-Sender: Sarath Subramanian References: <20171019045959.63799.701@reviews-vm2.apache.org> In-Reply-To: <20171019045959.63799.701@reviews-vm2.apache.org> Reply-To: Sarath Subramanian X-ReviewRequest-Repository: atlas archived-at: Tue, 24 Oct 2017 01:11:09 -0000 --===============8386617175335118280== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63136/#review189009 ----------------------------------------------------------- could you rebase the patch - Sarath Subramanian On Oct. 18, 2017, 9:59 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63136/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2017, 9:59 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-2218 > https://issues.apache.org/jira/browse/ATLAS-2218 > > > Repository: atlas > > > Description > ------- > > Currently UTs and ITs run under a single mvn goal "pre-integration-test", this change allows certain tests to run as unit-tests and the remainder run as integration-tests > > > Diffs > ----- > > webapp/pom.xml 7a868086 > > > Diff: https://reviews.apache.org/r/63136/diff/1/ > > > Testing > ------- > > mvn clean package run as expected > > mvn test -DskipITs don't run any Secure server tests or SSL tests (from webapp module) > mvn verify -pl webapp -DskipITs run all unit + pre-integration tests > > mvn test runs only UTs and no secure server, ssl or kerberos tests > mvn verify -pl webapp runs every single test under webapp > > > Thanks, > > Apoorv Naik > > --===============8386617175335118280==--