Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.apache.org
Content-Type: multipart/alternative;
 boundary="===============0269099314045065664=="
MIME-Version: 1.0
Subject: Re: Review Request 62175: [ATLAS-2119]: Implement update and delete
 operations for RelationshipREST
From: Madhan Neethiraj <madhan@apache.org>
To: Madhan Neethiraj <madhan@apache.org>,
 atlas <dev@atlas.incubator.apache.org>, Sarath Subramanian <sarath@apache.org>
Date: Fri, 13 Oct 2017 23:20:38 -0000
Message-ID: <20171013232038.21000.15948@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Madhan Neethiraj <noreply@reviews.apache.org>
References: <20170907221638.39549.78435@reviews-vm2.apache.org>
In-Reply-To: <20170907221638.39549.78435@reviews-vm2.apache.org>
Reply-To: Madhan Neethiraj <madhan@apache.org>
archived-at: Fri, 13 Oct 2017 23:20:45 -0000

--===============0269099314045065664==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62175/#review188042
-----------------------------------------------------------


notification/pom.xml
Line 1 (original), 1 (patched)
<https://reviews.apache.org/r/62175/#comment265119>

    This file has only whitespace changes; please revert.


repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
Lines 251 (patched)
<https://reviews.apache.org/r/62175/#comment265118>

    tagPropagation is not set in createRelationship() above. Please review.


repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
Lines 266 (patched)
<https://reviews.apache.org/r/62175/#comment265120>

    Update of relationships should send out notifications for changes in propagated tags - if any.


repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
Lines 431 (patched)
<https://reviews.apache.org/r/62175/#comment265121>

    Why not use tagPropagation setting from the relationShipType?


- Madhan Neethiraj


On Sept. 7, 2017, 10:16 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62175/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2017, 10:16 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2119
>     https://issues.apache.org/jira/browse/ATLAS-2119
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> * Implement update and delete relationship in RelationshipREST
> * Add propagateTags information to each relationship instance
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java bf098062 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java ec6161c0 
>   notification/pom.xml 9b369403 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 639077dd 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 1eb41832 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java 9b273193 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java b0940f67 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 36cd980f 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java 94cc5b93 
> 
> 
> Diff: https://reviews.apache.org/r/62175/diff/4/
> 
> 
> Testing
> -------
> 
> validated using POSTMAN Rest client.
> 
> Integration/Unit Tests in progress
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


--===============0269099314045065664==--