Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5D7BE200D27 for ; Wed, 11 Oct 2017 05:02:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5C0DD160BE1; Wed, 11 Oct 2017 03:02:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A232D160BE0 for ; Wed, 11 Oct 2017 05:02:10 +0200 (CEST) Received: (qmail 67557 invoked by uid 500); 11 Oct 2017 03:02:09 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 67524 invoked by uid 99); 11 Oct 2017 03:02:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Oct 2017 03:02:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0F10BDA2E3; Wed, 11 Oct 2017 03:02:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id pohFdB5ZSjRY; Wed, 11 Oct 2017 03:02:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4D8335F121; Wed, 11 Oct 2017 03:02:06 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 96400E0051; Wed, 11 Oct 2017 03:02:05 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 99762C402DD; Wed, 11 Oct 2017 03:02:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2345122742103299934==" MIME-Version: 1.0 Subject: Re: Review Request 62874: Hive hook OOM fix From: Madhan Neethiraj To: Ashutosh Mestry , Madhan Neethiraj , Sarath Subramanian Cc: Apoorv Naik , atlas Date: Wed, 11 Oct 2017 03:02:03 -0000 Message-ID: <20171011030203.33204.19181@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Madhan Neethiraj X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62874/ X-Sender: Madhan Neethiraj References: <20171011015026.33240.70872@reviews-vm2.apache.org> In-Reply-To: <20171011015026.33240.70872@reviews-vm2.apache.org> Reply-To: Madhan Neethiraj X-ReviewRequest-Repository: atlas archived-at: Wed, 11 Oct 2017 03:02:11 -0000 --===============2345122742103299934== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62874/#review187620 ----------------------------------------------------------- addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java Line 579 (original), 579 (patched) entities will have a maximum of 2 entities here, hence it is okay to batch them in a single message. - Madhan Neethiraj On Oct. 11, 2017, 1:50 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62874/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2017, 1:50 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-2198 > https://issues.apache.org/jira/browse/ATLAS-2198 > > > Repository: atlas > > > Description > ------- > > For the reported use case, Hive hook messages contains around 508 entities in a single message. > This causes the Base64 encoder to fail while memory allocation and the entire message gets dropped because the hive process dies. > > This fix splits one giant message for all entity into N small messages per entity (Referenceable) > > > Diffs > ----- > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java aca56454 > > > Diff: https://reviews.apache.org/r/62874/diff/2/ > > > Testing > ------- > > Fired reported command via beeline and verified "view" and it's col lineage shows up in Atlas UI. > > > Thanks, > > Apoorv Naik > > --===============2345122742103299934==--