atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sar...@apache.org>
Subject Re: Review Request 63417: ASTLAS-2242: gremlin3 traversals for discovery service
Date Mon, 30 Oct 2017 16:28:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63417/#review189608
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Oct. 30, 2017, 9:25 a.m., Graham Wallis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63417/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2017, 9:25 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-2242.patch
> This patch contains fixes for a couple of tests in GraphBackedDiscoveryServiceTest.
> Although in Atlas master a user will no longer be able to issue gremlin queries directly,
the unit tests of the graph should still be correct.
> This patch rectifies the gremlin3 traversals to return the correct types for vertex and
edge queries.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java a43e0236c67fa04c210ef4c302a9a2851cb0b250

>   repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
11980bec24a109cce7ee7b8c5d4a9f3d39ae124a 
> 
> 
> Diff: https://reviews.apache.org/r/63417/diff/1/
> 
> 
> Testing
> -------
> 
> Built and tested with janus provider
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message