atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Wallis <graham_wal...@uk.ibm.com>
Subject Re: Review Request 62889: ATLAS-1757 POM changes
Date Mon, 30 Oct 2017 16:27:32 GMT


> On Oct. 12, 2017, 3:56 p.m., David Radley wrote:
> > pom.xml
> > Line 585 (original), 584 (patched)
> > <https://reviews.apache.org/r/62889/diff/1/?file=1852385#file1852385line585>
> >
> >     I suggest changing the Jira to patch available and adding the url to the review
board there.

I'm not sure how to do that - is that the "Submit Patch" button?


> On Oct. 12, 2017, 3:56 p.m., David Radley wrote:
> > pom.xml
> > Line 586 (original), 585 (patched)
> > <https://reviews.apache.org/r/62889/diff/1/?file=1852385#file1852385line586>
> >
> >     For me the build is clean for titan0.
> >     For titan1, I get test failures :
> >     
> >     Tests run: 10, Failures: 6, Errors: 0, Skipped: 0, Time elapsed: 79.344 sec
<<< FAILURE! - in org.apache.atlas.repository.impexp.ExportServiceTest
> >     requestingDeptEntityFoundConnectedFetch_ContainsData(org.apache.atlas.repository.impexp.ExportServiceTest)
 Time elapsed: 2.612 sec  <<< FAILURE!
> >     java.lang.AssertionError: expected:<true> but was:<false>
> >     	at org.testng.Assert.fail(Assert.java:89)
> >     	at org.testng.Assert.failNotEquals(Assert.java:489)
> >     	at org.testng.Assert.assertTrue(Assert.java:37)
> >     	at org.testng.Assert.assertTrue(Assert.java:47)
> >     	at org.apache.atlas.repository.impexp.ExportServiceTest.verifyExportForHrDataForConnected(ExportServiceTest.java:341)
> >     	at org.apache.atlas.repository.impexp.ExportServiceTest.requestingDeptEntityFoundConnectedFetch_ContainsData(ExportServiceTest.java:253)
> >     
> >     requestingDeptEntityFoundFullFetch_ContainsData(org.apache.atlas.repository.impexp.ExportServiceTest)
 Time elapsed: 0.817 sec  <<< FAILURE!
> >     java.lang.AssertionError: expected:<true> but was:<false>
> >     	at org.testng.Assert.fail(Assert.java:89)
> >     	at org.testng.Assert.failNotEquals(Assert.java:489)
> >     	at org.testng.Assert.assertTrue(Assert.java:37)
> >     	at org.testng.Assert.assertTrue(Assert.java:47)
> >     	at org.apache.atlas.repository.impexp.ExportServiceTest.verifyExportForHrData(ExportServiceTest.java:328)
> >     	at org.apache.atlas.repository.impexp.ExportServiceTest.requestingDeptEntityFoundFullFetch_ContainsData(ExportServiceTest.java:246)
> >     
> >     requestingEmployeeEntityFoundConnectedFetch_ContainsData(org.apache.atlas.repository.impexp.ExportServiceTest)
 Time elapsed: 0.5 sec  <<< FAILURE!
> >     java.lang.AssertionError: expected:<2> but was:<0>
> >     	at org.testng.Assert.fail(Assert.java:89)
> >     	at org.testng.Assert.failNotEquals(Assert.java:489)
> >     	at org.testng.Assert.assertEquals(Assert.java:118)
> >     	at org.testng.Assert.assertEquals(Assert.java:365)
> >     	at org.testng.Assert.assertEquals(Assert.java:375)
> >     	at org.apache.atlas.repository.impexp.ExportServiceTest.verifyExportForEmployeeData(ExportServiceTest.java:312)
> >     	at org.apache.atlas.repository.impexp.ExportServiceTest.requestingEmployeeEntityFoundConnectedFetch_ContainsData(ExportServiceTest.java:259)
> >     
> >     requestingEntityFoundDefaultFetch_ContainsData(org.apache.atlas.repository.impexp.ExportServiceTest)
 Time elapsed: 0.911 sec  <<< FAILURE!
> >     java.lang.AssertionError: expected:<true> but was:<false>
> >     	at org.testng.Assert.fail(Assert.java:89)
> >     	at org.testng.Assert.failNotEquals(Assert.java:489)
> >     	at org.testng.Assert.assertTrue(Assert.java:37)
> >     	at org.testng.Assert.assertTrue(Assert.java:47)
> >     	at org.apache.atlas.repository.impexp.ExportServiceTest.verifyExportForHrData(ExportServiceTest.java:328)
> >     	at org.apache.atlas.repository.impexp.ExportServiceTest.requestingEntityFoundDefaultFetch_ContainsData(ExportServiceTest.java:225)
> >     
> >     requestingHrEntityWithMatchTypeContains_ContainsData(org.apache.atlas.repository.impexp.ExportServiceTest)
 Time elapsed: 0.804 sec  <<< FAILURE!
> >     java.lang.AssertionError: expected:<true> but was:<false>
> >     	at org.testng.Assert.fail(Assert.java:89)
> >     	at org.testng.Assert.failNotEquals(Assert.java:489)
> >     	at org.testng.Assert.assertTrue(Assert.java:37)
> >     	at org.testng.Assert.assertTrue(Assert.java:47)
> >     	at org.apache.atlas.repository.impexp.ExportServiceTest.verifyExportForHrData(ExportServiceTest.java:328)
> >     	at org.apache.atlas.repository.impexp.ExportServiceTest.requestingHrEntityWithMatchTypeContains_ContainsData(ExportServiceTest.java:232)
> >     
> >     requestingHrEntityWithMatchTypeEndsWith_ContainsData(org.apache.atlas.repository.impexp.ExportServiceTest)
 Time elapsed: 0.766 sec  <<< FAILURE!
> >     java.lang.AssertionError: expected:<true> but was:<false>
> >     	at org.testng.Assert.fail(Assert.java:89)
> >     	at org.testng.Assert.failNotEquals(Assert.java:489)
> >     	at org.testng.Assert.assertTrue(Assert.java:37)
> >     	at org.testng.Assert.assertTrue(Assert.java:47)
> >     	at org.apache.atlas.repository.impexp.ExportServiceTest.verifyExportForHrData(ExportServiceTest.java:328)
> >     	at org.apache.atlas.repository.impexp.ExportServiceTest.requestingHrEntityWithMatchTypeEndsWith_ContainsData(ExportServiceTest.java:239)
> >     
> >     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
support was removed in 8.0
> >     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
support was removed in 8.0
> >     Running org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateV1Test
> >     Running org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateSoftDeleteV1Test
> >     Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 33.992 sec -
in org.apache.atlas.repository.store.graph.v1.AtlasDeleteHandlerV1Test
> >     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
support was removed in 8.0
> >     Running org.apache.atlas.repository.store.graph.v1.SoftDeleteHandlerV1Test
> >     Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.599 sec -
in org.apache.atlas.repository.store.graph.v1.AtlasEntityStoreV1BulkImportPercentTest
> >     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
support was removed in 8.0
> >     Running org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest
> >     Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 33.395 sec -
in org.apache.atlas.repository.store.graph.v1.AtlasRelationshipStoreV1Test
> >     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
support was removed in 8.0
> >     Running org.apache.atlas.repository.typestore.StoreBackedTypeCacheTest
> >     Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 51.081 sec -
in org.apache.atlas.repository.store.graph.v1.AtlasEntityDefStoreV1Test
> >     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
support was removed in 8.0
> >     Running org.apache.atlas.repository.userprofile.UserProfileServiceTest
> >     Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 52.078 sec
- in org.apache.atlas.repository.store.graph.v1.AtlasRelationshipDefStoreV1Test
> >     Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.977 sec -
in org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateV1Test
> >     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
support was removed in 8.0
> >     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
support was removed in 8.0
> >     Running org.apache.atlas.RepositoryServiceLoadingTest
> >     Running org.apache.atlas.service.DefaultMetadataServiceTest
> >     Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 132.688 sec
- in org.apache.atlas.repository.impexp.ImportServiceTest
> >     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
support was removed in 8.0
> >     Running org.apache.atlas.service.StoreBackedTypeCacheMetadataServiceTest
> >     Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 75.486 sec <<<
FAILURE! - in org.apache.atlas.repository.store.graph.v1.AtlasRelationshipStoreHardDeleteV1Test
> >     testRelationshipAttributeUpdate_NonComposite_OneToMany(org.apache.atlas.repository.store.graph.v1.AtlasRelationshipStoreHardDeleteV1Test)
 Time elapsed: 0.792 sec  <<< FAILURE!
> >     java.lang.AssertionError: expected:<3> but was:<4>
> >     	at org.testng.Assert.fail(Assert.java:89)
> >     	at org.testng.Assert.failNotEquals(Assert.java:489)
> >     	at org.testng.Assert.assertEquals(Assert.java:118)
> >     	at org.testng.Assert.assertEquals(Assert.java:365)
> >     	at org.testng.Assert.assertEquals(Assert.java:375)
> >     	at org.apache.atlas.repository.store.graph.v1.AtlasRelationshipStoreV1Test.testRelationshipAttributeUpdate_NonComposite_OneToMany(AtlasRelationshipStoreV1Test.java:331)
> >     	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> >     	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> >     	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> >     	at java.lang.reflect.Method.invoke(Method.java:498)
> >     	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
> >     	at org.testng.internal.Invoker.invokeMethod(Invoker.java:673)
> >     	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:842)
> >     	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1166)
> >     	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:125)
> >     	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:109)
> >     	at org.testng.TestRunner.runWorkers(TestRunner.java:1178)
> >     	at org.testng.TestRunner.privateRun(TestRunner.java:757)
> >     	at org.testng.TestRunner.run(TestRunner.java:608)
> >     	at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
> >     	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329)
> >     	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291)
> >     	at org.testng.SuiteRunner.run(SuiteRunner.java:240)
> >     	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
> >     	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
> >     	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1158)
> >     	at org.testng.TestNG.runSuitesLocally(TestNG.java:1083)
> >     	at org.testng.TestNG.run(TestNG.java:999)
> >     	at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:115)
> >     	at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeSingleClass(TestNGDirectoryTestSuite.java:129)
> >     	at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:113)
> >     	at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:111)
> >     	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
> >     	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
> >     	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
> >     
> >     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
support was removed in 8.0
> >     Running org.apache.atlas.services.MetricsServiceTest
> >     Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 77.768 sec -
in org.apache.atlas.repository.store.graph.v1.AtlasRelationshipStoreSoftDeleteV1Test
> >     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
support was removed in 8.0
> >     Running org.apache.atlas.TestModules
> >     Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 105.002 sec
- in org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStoreTest
> >     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
support was removed in 8.0
> >     Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 57.036 sec -
in org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest
> >     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
support was removed in 8.0
> >     Running org.apache.atlas.TestUtils
> >     Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 93.578 sec
- in org.apache.atlas.repository.store.graph.v1.AtlasEntityStoreV1Test
> >     Running org.apache.atlas.util.CompiledQueryCacheKeyTest
> >     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
support was removed in 8.0
> >     Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 78.32 sec -
in org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateHardDeleteV1Test
> >     Running org.apache.atlas.utils.ObjectUpdateSynchronizerTest
> >     Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 78.195 sec -
in org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateSoftDeleteV1Test
> >     Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 60.3 sec - in
org.apache.atlas.repository.typestore.StoreBackedTypeCacheTest
> >     Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 47.799 sec -
in org.apache.atlas.RepositoryServiceLoadingTest
> >     Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 102.962 sec
- in org.apache.atlas.repository.store.graph.v1.HardDeleteHandlerV1Test
> >     Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 30.568 sec -
in org.apache.atlas.TestModules
> >     Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.802 sec -
in org.apache.atlas.TestUtils
> >     Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.21 sec -
in org.apache.atlas.util.CompiledQueryCacheKeyTest
> >     Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.732 sec -
in org.apache.atlas.utils.ObjectUpdateSynchronizerTest
> >     Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 38.527 sec -
in org.apache.atlas.services.MetricsServiceTest
> >     Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 74.808 sec
- in org.apache.atlas.repository.userprofile.UserProfileServiceTest
> >     Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 97.071 sec
- in org.apache.atlas.repository.store.graph.v1.SoftDeleteHandlerV1Test
> >     Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 54.343 sec -
in org.apache.atlas.service.StoreBackedTypeCacheMetadataServiceTest
> >     Tests run: 27, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 78.96 sec -
in org.apache.atlas.service.DefaultMetadataServiceTest
> >     Tests run: 338, Failures: 10, Errors: 0, Skipped: 1, Time elapsed: 305.543 sec
<<< FAILURE! - in org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest
> >     testDslSearchUsingLikeOperator(org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest)
 Time elapsed: 3.608 sec  <<< FAILURE!
> >     org.apache.atlas.discovery.DiscoveryException: Invalid expression : hive_table
where name like "sa?es*"
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:342)
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:325)
> >     	at org.apache.atlas.query.GremlinEvaluator.evaluate(GremlinEvaluator.scala:86)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.evaluate(GraphBackedDiscoveryService.java:155)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.searchByDSL(GraphBackedDiscoveryService.java:141)
> >     	at org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:60)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.runQuery(GraphBackedDiscoveryServiceTest.java:991)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator(GraphBackedDiscoveryServiceTest.java:301)
> >     
> >     testDslSearchUsingLikeOperator(org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest)
 Time elapsed: 1.331 sec  <<< FAILURE!
> >     org.apache.atlas.discovery.DiscoveryException: Invalid expression : hive_db
where name like "R*"
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:342)
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:325)
> >     	at org.apache.atlas.query.GremlinEvaluator.evaluate(GremlinEvaluator.scala:86)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.evaluate(GraphBackedDiscoveryService.java:155)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.searchByDSL(GraphBackedDiscoveryService.java:141)
> >     	at org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:60)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.runQuery(GraphBackedDiscoveryServiceTest.java:991)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator(GraphBackedDiscoveryServiceTest.java:301)
> >     
> >     testDslSearchUsingLikeOperator(org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest)
 Time elapsed: 1.582 sec  <<< FAILURE!
> >     org.apache.atlas.discovery.DiscoveryException: Invalid expression : hive_db
where hive_db.name like "R???rt?*" or hive_db.name like "S?l?s" or hive_db.name like"Log*"
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:342)
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:325)
> >     	at org.apache.atlas.query.GremlinEvaluator.evaluate(GremlinEvaluator.scala:86)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.evaluate(GraphBackedDiscoveryService.java:155)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.searchByDSL(GraphBackedDiscoveryService.java:141)
> >     	at org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:60)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.runQuery(GraphBackedDiscoveryServiceTest.java:991)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator(GraphBackedDiscoveryServiceTest.java:301)
> >     
> >     testDslSearchUsingLikeOperator(org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest)
 Time elapsed: 1.358 sec  <<< FAILURE!
> >     org.apache.atlas.discovery.DiscoveryException: Invalid expression : hive_db
where hive_db.name like "R???rt?*" and hive_db.name like "S?l?s" and hive_db.name like"Log*"
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:342)
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:325)
> >     	at org.apache.atlas.query.GremlinEvaluator.evaluate(GremlinEvaluator.scala:86)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.evaluate(GraphBackedDiscoveryService.java:155)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.searchByDSL(GraphBackedDiscoveryService.java:141)
> >     	at org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:60)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.runQuery(GraphBackedDiscoveryServiceTest.java:991)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator(GraphBackedDiscoveryServiceTest.java:301)
> >     
> >     testDslSearchUsingLikeOperator(org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest)
 Time elapsed: 2.394 sec  <<< FAILURE!
> >     org.apache.atlas.discovery.DiscoveryException: Invalid expression : hive_table
where name like 'sales*', db where name like 'Sa?es'
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:342)
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:325)
> >     	at org.apache.atlas.query.GremlinEvaluator.evaluate(GremlinEvaluator.scala:86)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.evaluate(GraphBackedDiscoveryService.java:155)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.searchByDSL(GraphBackedDiscoveryService.java:141)
> >     	at org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:60)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.runQuery(GraphBackedDiscoveryServiceTest.java:991)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator(GraphBackedDiscoveryServiceTest.java:301)
> >     
> >     testDslSearchUsingLikeOperator(org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest)
 Time elapsed: 1.943 sec  <<< FAILURE!
> >     org.apache.atlas.discovery.DiscoveryException: Invalid expression : hive_table
where name like 'sales*' and db.name like 'Sa?es'
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:342)
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:325)
> >     	at org.apache.atlas.query.GremlinEvaluator.evaluate(GremlinEvaluator.scala:86)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.evaluate(GraphBackedDiscoveryService.java:155)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.searchByDSL(GraphBackedDiscoveryService.java:141)
> >     	at org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:60)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.runQuery(GraphBackedDiscoveryServiceTest.java:991)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator(GraphBackedDiscoveryServiceTest.java:301)
> >     
> >     testDslSearchUsingLikeOperator(org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest)
 Time elapsed: 1.528 sec  <<< FAILURE!
> >     org.apache.atlas.discovery.DiscoveryException: Invalid expression : hive_table
where db.name like "Sa*"
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:342)
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:325)
> >     	at org.apache.atlas.query.GremlinEvaluator.evaluate(GremlinEvaluator.scala:86)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.evaluate(GraphBackedDiscoveryService.java:155)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.searchByDSL(GraphBackedDiscoveryService.java:141)
> >     	at org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:60)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.runQuery(GraphBackedDiscoveryServiceTest.java:991)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator(GraphBackedDiscoveryServiceTest.java:301)
> >     
> >     testDslSearchUsingLikeOperator(org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest)
 Time elapsed: 2.864 sec  <<< FAILURE!
> >     org.apache.atlas.discovery.DiscoveryException: Invalid expression : hive_table
where db.name like "Sa*" and name like "*dim"
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:342)
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:325)
> >     	at org.apache.atlas.query.GremlinEvaluator.evaluate(GremlinEvaluator.scala:86)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.evaluate(GraphBackedDiscoveryService.java:155)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.searchByDSL(GraphBackedDiscoveryService.java:141)
> >     	at org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:60)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.runQuery(GraphBackedDiscoveryServiceTest.java:991)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator(GraphBackedDiscoveryServiceTest.java:301)
> >     
> >     testGremlinSearchReturnEdgeIds(org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest)
 Time elapsed: 1.79 sec  <<< FAILURE!
> >     org.apache.atlas.discovery.DiscoveryException: org.apache.atlas.exception.AtlasBaseException:
Gremlin script execution failed: g.E.range(0,0).collect()
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:342)
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:325)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.searchByGremlin(GraphBackedDiscoveryService.java:213)
> >     	at org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:60)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.testGremlinSearchReturnEdgeIds(GraphBackedDiscoveryServiceTest.java:247)
> >     
> >     testGremlinSearchReturnVertexId(org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest)
 Time elapsed: 2.073 sec  <<< FAILURE!
> >     org.apache.atlas.discovery.DiscoveryException: org.apache.atlas.exception.AtlasBaseException:
Gremlin script execution failed: g.V.range(0,0).collect()
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:342)
> >     	at org.apache.atlas.repository.graphdb.titan1.Titan1Graph.executeGremlinScript(Titan1Graph.java:325)
> >     	at org.apache.atlas.discovery.graph.GraphBackedDiscoveryService.searchByGremlin(GraphBackedDiscoveryService.java:213)
> >     	at org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:60)
> >     	at org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.testGremlinSearchReturnVertexId(GraphBackedDiscoveryServiceTest.java:236)
> >     
> >     Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 307.92 sec -
in org.apache.atlas.repository.graph.GraphRepoMapperScaleTest
> >     
> >     Results :
> >     
> >     Failed tests: 
> >     org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator(org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest)
> >       Run 1: GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator:301->runQuery:991
» Discovery
> >       Run 2: GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator:301->runQuery:991
» Discovery
> >       Run 3: GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator:301->runQuery:991
» Discovery
> >       Run 4: GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator:301->runQuery:991
» Discovery
> >       Run 5: GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator:301->runQuery:991
» Discovery
> >       Run 6: GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator:301->runQuery:991
» Discovery
> >       Run 7: GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator:301->runQuery:991
» Discovery
> >       Run 8: GraphBackedDiscoveryServiceTest.testDslSearchUsingLikeOperator:301->runQuery:991
» Discovery
> >     
> >       GraphBackedDiscoveryServiceTest.testGremlinSearchReturnEdgeIds:247 » Discovery
> >       GraphBackedDiscoveryServiceTest.testGremlinSearchReturnVertexId:236 » Discovery
> >       ExportServiceTest.requestingDeptEntityFoundConnectedFetch_ContainsData:253->verifyExportForHrDataForConnected:341
expected:<true> but was:<false>
> >       ExportServiceTest.requestingDeptEntityFoundFullFetch_ContainsData:246->verifyExportForHrData:328
expected:<true> but was:<false>
> >       ExportServiceTest.requestingEmployeeEntityFoundConnectedFetch_ContainsData:259->verifyExportForEmployeeData:312
expected:<2> but was:<0>
> >       ExportServiceTest.requestingEntityFoundDefaultFetch_ContainsData:225->verifyExportForHrData:328
expected:<true> but was:<false>
> >       ExportServiceTest.requestingHrEntityWithMatchTypeContains_ContainsData:232->verifyExportForHrData:328
expected:<true> but was:<false>
> >       ExportServiceTest.requestingHrEntityWithMatchTypeEndsWith_ContainsData:239->verifyExportForHrData:328
expected:<true> but was:<false>
> >       AtlasRelationshipStoreHardDeleteV1Test>AtlasRelationshipStoreV1Test.testRelationshipAttributeUpdate_NonComposite_OneToMany:331
expected:<3> but was:<4>
> >     
> >     Tests run: 828, Failures: 10, Errors: 0, Skipped: 15

These all look like 'standard failures' - meaning that I saw (roughly) the same failures regardless
of POM changes. There are a number of TP3 specific failures, some of which are due to odd
effects like the number of expected results being 4 instead of 3. This is the problem I mentioned
in that when changing relationships, there is additional modification of entities (that you
would not expect to be modified). The Mike entity is an example in the test in which before
state is "Max -> friends -> Mike,John" and after state is "Max -> friends -> Julius,John".
For some reason (with TP3 only) Mike is updated. For me the above failed in a soft delete
rather than a hard delete as above.


> On Oct. 12, 2017, 3:56 p.m., David Radley wrote:
> > pom.xml
> > Lines 586 (patched)
> > <https://reviews.apache.org/r/62889/diff/1/?file=1852385#file1852385line587>
> >
> >     I suggest updating the readme with the Maven graphprovider details. I would
suggest a follow on Jira to update the documentation to document the new Maven command lines.

Will do - I wasn't sure how doc changes are organised but will come chat to you.


> On Oct. 12, 2017, 3:56 p.m., David Radley wrote:
> > repository/pom.xml
> > Lines 35 (patched)
> > <https://reviews.apache.org/r/62889/diff/1/?file=1852386#file1852386line35>
> >
> >     I think this results in the warning when I apply the patch. : 1 line adds whitespace
errors.

Yep - more whitespace weirdness. Will fix.


> On Oct. 12, 2017, 3:56 p.m., David Radley wrote:
> > repository/pom.xml
> > Line 151 (original), 172 (patched)
> > <https://reviews.apache.org/r/62889/diff/1/?file=1852386#file1852386line179>
> >
> >     I think you are backing out the change that replaced powermock.

OK - thanks for spotting that - I didn't intend to but must have got my merge conflicts wrong.
Will rework.


- Graham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62889/#review187770
-----------------------------------------------------------


On Oct. 11, 2017, 1:43 p.m., Graham Wallis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62889/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2017, 1:43 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch contains changes to 13 POM files to simplify the selection of graph database,
which should be 
> performed by specifying the GRAPH-PROVIDER system variable, e.g.
> 
> mvn clean install -DGRAPH-PROVIDER=titan0
> 
> If GRAPH-PROVIDER is not specified, the default graph database is selected. This is currently
titan0
> If GRAPH-PROVIDER is specified, valid values are titan0 and titan1.
> 
> The old graph profiles ('titan0', 'titan1') have been removed.
> 
> This patch also simplifies dependency management in the POM files and removes a number
of duplicate entries.
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml 0d13ae47bc1ce1890d706c6ee6c2d3ddeeb42d73 
>   distro/pom.xml 9bea00852cb10ddca363ef1e726487394f6947f3 
>   distro/src/conf/atlas-application.properties 585a57919d8ce5f5a921918c27e45c0dbc660043

>   graphdb/api/pom.xml 186e7455353c4d073f297868cc884c178d102106 
>   graphdb/graphdb-impls/pom.xml 62a09944f7655098319d477d362c7181f4b373d1 
>   graphdb/titan0/pom.xml df89e4fa52581f60e5ba962b114911a1b582f0b0 
>   graphdb/titan0/src/test/resources/atlas-application.properties 3058330668424e0b860d0bfe932f78bfb3db8ec1

>   graphdb/titan1/pom.xml 146155b73c24dbe10408a5d7071d6c9df02cf514 
>   graphdb/titan1/src/test/resources/atlas-application.properties 99fe18a9d177403c8d7b41f2486709f1c6f24c3d

>   pom.xml 39ae6e7239b690cbf6dff69028b0d6e392777415 
>   repository/pom.xml b7eedde0a30a1716bc9665f2acfa02e169ba183f 
>   typesystem/src/test/resources/atlas-application.properties d7537a516551d745fa0ab5f854c9207cb7a2cfc1

>   webapp/pom.xml bfa79e8101f1de962c26c48e3c71beb8e73b8876 
> 
> 
> Diff: https://reviews.apache.org/r/62889/diff/1/
> 
> 
> Testing
> -------
> 
> Builds before and after POM changes with no new test failures being introduced.
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message