atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 63241: ATLAS-2219 : UI Regression , Unable to provide exponential values for tag attribute values in UI.
Date Wed, 25 Oct 2017 04:28:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63241/#review189148
-----------------------------------------------------------




dashboardv2/public/js/views/tag/addTagModalView.js
Lines 316 (patched)
<https://reviews.apache.org/r/63241/#comment266077>

    Decimal/exponent values are not for "long" type, right? Why is it grouped with "float"
or "double"?


- Madhan Neethiraj


On Oct. 24, 2017, 9:52 a.m., pratik pandey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63241/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2017, 9:52 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha
Sainath.
> 
> 
> Bugs: ATLAS-2219
>     https://issues.apache.org/jira/browse/ATLAS-2219
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> For tag attributes of data type double , float etc, the corresponding text box is not
accepting 'E' character for providing exponential values.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/css/scss/form.scss 694e885 
>   dashboardv2/public/js/utils/Enums.js 78445e1 
>   dashboardv2/public/js/utils/Overrides.js dd36859 
>   dashboardv2/public/js/views/tag/addTagModalView.js a169867 
> 
> 
> Diff: https://reviews.apache.org/r/63241/diff/1/
> 
> 
> Testing
> -------
> 
> Unit testing is done.
> Tested by adding value for attributes for float,double type with 
>  0123,123.009,123E9,123e9,12.23e9,12.23E9
> -0123,-123.009,-123E9,-123e9,-12.23e9,-12.23E9
> 
> 
> Thanks,
> 
> pratik pandey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message