atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 62984: ATLAS-2210 Get and Delete Relationships in AtlasClientV2
Date Mon, 16 Oct 2017 18:44:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62984/#review188186
-----------------------------------------------------------




client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 387 (patched)
<https://reviews.apache.org/r/62984/#comment265221>

    Yes, the responseType param should be set to null for methods with 204 response(no body).

    
    ```java 
    
    public void deleteRelationshipByGuid(String guid) throws AtlasServiceException {
        callAPI(API_V2.DELETE_RELATIONSHIP_BY_GUID, null, null, guid);
    }
    
    ```
    
    This should work.


- Apoorv Naik


On Oct. 13, 2017, 6:48 p.m., Andrew Hulbert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62984/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2017, 6:48 p.m.)
> 
> 
> Review request for atlas and Apoorv Naik.
> 
> 
> Bugs: ATLAS-2210
>     https://issues.apache.org/jira/browse/ATLAS-2210
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Add calls to get and delete relationships to AtlasClientV2
> 
> 
> Diffs
> -----
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 24a3ef6 
> 
> 
> Diff: https://reviews.apache.org/r/62984/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Hulbert
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message