atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keval bhatt <kbh...@apache.org>
Subject Review Request 62838: ATLAS-2171 : Error in constructing base path for UI API when accessing Atlas via knox proxy without "/" at the end
Date Mon, 09 Oct 2017 14:04:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62838/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath.


Bugs: ATLAS-2171
    https://issues.apache.org/jira/browse/ATLAS-2171


Repository: atlas


Description
-------

1. Enabled knox proxy for atlas.
2.Accessed Atlas UI via proxy using https://knox_gateway:8443/gateway/ui/atlas
3. Provided admin username and password and logged into Atlas
4. Now, opened another tab in browser with URL: https://knox_gateway:8443/gateway/ui/atlas

UI is loaded without data because API path is not formed properly.

If the URL is accessed with "/" at the end, logs in as admin user and all operations work
fine.
Example : https://knox_gateway:8443/gateway/ui/atlas/


Fix detail.

Added one regex to form correct API base url.

Regex condition.

it is checking if url exnds with slash then exclude it or if url ends with file extention
i.e (.html or .jsp) then exclude that file extention with slash.

Example of regex input = output:

1. https://knox_gateway:8443/gateway/ui/atlas/ = https://knox_gateway:8443/gateway/ui/atlas
2. https://knox_gateway:8443/gateway/ui/atlas/index.html = https://knox_gateway:8443/gateway/ui/atlas
3. https://knox_gateway:8443/gateway/ui/atlas/index.jsp = https://knox_gateway:8443/gateway/ui/atlas
4. https://knox_gateway:8443/gateway/ui/atlas = https://knox_gateway:8443/gateway/ui/atlas


Diffs
-----

  dashboardv2/public/css/scss/loader.scss d323212 
  dashboardv2/public/index.html.tpl f13f34a 
  dashboardv2/public/js/templates/business_catalog/SideNavLayoutView_tmpl.html 3f4c11a 
  dashboardv2/public/js/utils/UrlLinks.js 913df24 
  dashboardv2/public/js/utils/Utils.js 1de2106 
  dashboardv2/public/js/views/business_catalog/SideNavLayoutView.js 1a2590c 
  dashboardv2/public/js/views/graph/LineageLayoutView.js 46f7117 


Diff: https://reviews.apache.org/r/62838/diff/1/


Testing
-------

Tested with normal url and also proxy url its working as expected.


Thanks,

keval bhatt


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message