Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 833732004F5 for ; Fri, 1 Sep 2017 14:19:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 81B6816CDFA; Fri, 1 Sep 2017 12:19:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C822D16CDF8 for ; Fri, 1 Sep 2017 14:19:08 +0200 (CEST) Received: (qmail 82696 invoked by uid 500); 1 Sep 2017 12:19:07 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 82685 invoked by uid 99); 1 Sep 2017 12:19:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Sep 2017 12:19:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7FDCDC37D0 for ; Fri, 1 Sep 2017 12:19:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 9sk2xrJRTbdn for ; Fri, 1 Sep 2017 12:19:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3E8C36126D for ; Fri, 1 Sep 2017 12:19:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 45F1EE0635 for ; Fri, 1 Sep 2017 12:19:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4F22324167 for ; Fri, 1 Sep 2017 12:19:00 +0000 (UTC) Date: Fri, 1 Sep 2017 12:19:00 +0000 (UTC) From: "David Radley (JIRA)" To: dev@atlas.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (ATLAS-2070) Investigate why AtlasTypeRegistry caches elements without resolve references being run on them MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 01 Sep 2017 12:19:09 -0000 [ https://issues.apache.org/jira/browse/ATLAS-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Radley resolved ATLAS-2070. --------------------------------- Resolution: Invalid This is part of the Atlas design > Investigate why AtlasTypeRegistry caches elements without resolve references being run on them > ---------------------------------------------------------------------------------------------- > > Key: ATLAS-2070 > URL: https://issues.apache.org/jira/browse/ATLAS-2070 > Project: Atlas > Issue Type: Bug > Reporter: David Radley > > During Jira 2029, I realised that AtlasTypeRegistry contains a map of the classificationTypes that did not have resolve references run on them. This means when a rest call to add a classificaiton to an entity comes in, AtlasEntityStoreV1 validateEntityAssociations calls AtlasClassificationType classificationType = typeRegistry.getClassificationTypeByName(newClassification); > This picks up the classificationType. Jira 2029 then resolves the references. > This Jira is to investigate whether the typeRegistry should store AtlasclassificationTypes with resolve references run on them. This would mean rewriting the junits. > Note constructing a classificationType passing a registry results in the resolve references being run. The other AtlasClassificationType constructor used by the junits and the typeregistry does not result in the resolve references being run. > If we can we should cache the resolve reference versions of the AtlasClassificationTypes - otehrwise callers of it get incomplete AltasClassificationTypes. > -- This message was sent by Atlassian JIRA (v6.4.14#64029)