Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2E771200D0F for ; Fri, 29 Sep 2017 20:16:41 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2CDF91609D1; Fri, 29 Sep 2017 18:16:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2501C1609BC for ; Fri, 29 Sep 2017 20:16:39 +0200 (CEST) Received: (qmail 88819 invoked by uid 500); 29 Sep 2017 18:16:39 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 88803 invoked by uid 99); 29 Sep 2017 18:16:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Sep 2017 18:16:38 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7AFBC181441; Fri, 29 Sep 2017 18:16:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id eAsN34DoNyKV; Fri, 29 Sep 2017 18:16:35 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 65AF75FDE7; Fri, 29 Sep 2017 18:16:35 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B3FC4E0931; Fri, 29 Sep 2017 18:16:34 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A2650C4083E; Fri, 29 Sep 2017 18:16:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8911478431722416887==" MIME-Version: 1.0 Subject: Re: Review Request 61670: ATLAS-1880: Integration tests for the search functionality From: Apoorv Naik To: Ashutosh Mestry , Madhan Neethiraj , Sarath Subramanian Cc: Apoorv Naik , atlas Date: Fri, 29 Sep 2017 18:16:34 -0000 Message-ID: <20170929181634.891.38121@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Apoorv Naik X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61670/ X-Sender: Apoorv Naik References: <20170815192439.37511.67620@reviews-vm2.apache.org> In-Reply-To: <20170815192439.37511.67620@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/gte.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/combination/filter/hdfs_path-fooTag-queryText.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/eq.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/contains.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/boolean/hive_table/eq.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/gt.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/combination/hive_column-col104.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/lt.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/lt.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/gt.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/gte.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/like.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/in.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/gte.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/boolean/hive_table/neq.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/eq.json X-ReviewBoard-Diff-For: webapp/src/test/resources/DefaultDB-3-New.zip X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/utils/TestResourceFileUtils.java X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/endsWith.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/neq.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/lte.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/hive_table.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/neq.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/lte.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/combination/hive_table-fooTag.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/gt.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/gt.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_column/contains.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/startsWith.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/combination/hdfs_path-fooTag.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/lt.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/eq.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/combination/hdfs_path-fooTag-queryText.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/neq.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/lt.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/neq.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_column/endsWith.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/eq.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/tag/fooTag.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/gte.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/neq.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_column/like.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/lte.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/eq.json X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/lte.json X-ReviewBoard-Diff-For: webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java X-ReviewBoard-Diff-For: webapp/src/test/resources/json/search-parameters/combination/specialChars.json X-ReviewBoard-Diff-For: webapp/src/test/resources/hive-db-50-tables.zip Reply-To: Apoorv Naik X-ReviewRequest-Repository: atlas archived-at: Fri, 29 Sep 2017 18:16:41 -0000 --===============8911478431722416887== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61670/ ----------------------------------------------------------- (Updated Sept. 29, 2017, 6:16 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian. Changes ------- Updated the client to include the import API, added search parameter JSONs under the webapp test resources Summary (updated) ----------------- ATLAS-1880: Integration tests for the search functionality Bugs: ATLAS-1954 https://issues.apache.org/jira/browse/ATLAS-1954 Repository: atlas Description (updated) ------- ITs for ATLAS-1880 Diffs (updated) ----- client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java 5e1d1018 client/pom.xml b065833e pom.xml f793321c repository/src/test/java/org/apache/atlas/discovery/EntityDiscoveryServiceTest.java 91d163ca repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java b24774d6 repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java cc1d2b3d repository/src/test/java/org/apache/atlas/utils/TestResourceFileUtils.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java PRE-CREATION webapp/src/test/resources/DefaultDB-3-New.zip PRE-CREATION webapp/src/test/resources/hive-db-50-tables.zip PRE-CREATION webapp/src/test/resources/json/search-parameters/combination/filter/hdfs_path-fooTag-queryText.json PRE-CREATION webapp/src/test/resources/json/search-parameters/combination/hdfs_path-fooTag-queryText.json PRE-CREATION webapp/src/test/resources/json/search-parameters/combination/hdfs_path-fooTag.json PRE-CREATION webapp/src/test/resources/json/search-parameters/combination/hive_column-col104.json PRE-CREATION webapp/src/test/resources/json/search-parameters/combination/hive_table-fooTag.json PRE-CREATION webapp/src/test/resources/json/search-parameters/combination/specialChars.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/boolean/hive_table/eq.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/boolean/hive_table/neq.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/eq.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/gt.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/gte.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/lt.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/lte.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/neq.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/eq.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/gt.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/gte.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/lt.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/lte.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/neq.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/hive_table.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/eq.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/gt.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/gte.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/lt.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/lte.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/neq.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/eq.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/gt.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/gte.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/lt.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/lte.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/neq.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_column/contains.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_column/endsWith.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_column/like.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/contains.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/endsWith.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/eq.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/in.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/like.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/neq.json PRE-CREATION webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/startsWith.json PRE-CREATION webapp/src/test/resources/json/search-parameters/tag/fooTag.json PRE-CREATION Diff: https://reviews.apache.org/r/61670/diff/2/ Changes: https://reviews.apache.org/r/61670/diff/1-2/ Testing (updated) ------- mvn clean package executes successfully Test runs from IDE successfully Thanks, Apoorv Naik --===============8911478431722416887==--