Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3005E200D0F for ; Fri, 29 Sep 2017 17:49:13 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2D3391609D1; Fri, 29 Sep 2017 15:49:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 712BD1609C5 for ; Fri, 29 Sep 2017 17:49:12 +0200 (CEST) Received: (qmail 66051 invoked by uid 500); 29 Sep 2017 15:49:11 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 66036 invoked by uid 99); 29 Sep 2017 15:49:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Sep 2017 15:49:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D35EC181BA6; Fri, 29 Sep 2017 15:49:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id nhnL9M47ObTk; Fri, 29 Sep 2017 15:49:10 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id AE8465FD33; Fri, 29 Sep 2017 15:49:09 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 53DF3E00A7; Fri, 29 Sep 2017 15:49:09 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 4116DC40845; Fri, 29 Sep 2017 15:49:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7508711854437307403==" MIME-Version: 1.0 Subject: Re: Review Request 62679: ATLAS-2184: IS_NULL and NOT_NULL operator support From: Apoorv Naik To: Madhan Neethiraj Cc: Apoorv Naik , atlas Date: Fri, 29 Sep 2017 15:49:09 -0000 Message-ID: <20170929154909.861.96298@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Apoorv Naik X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62679/ X-Sender: Apoorv Naik References: <20170929140511.891.2310@reviews-vm2.apache.org> In-Reply-To: <20170929140511.891.2310@reviews-vm2.apache.org> Reply-To: Apoorv Naik X-ReviewRequest-Repository: atlas archived-at: Fri, 29 Sep 2017 15:49:13 -0000 --===============7508711854437307403== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62679/ ----------------------------------------------------------- (Updated Sept. 29, 2017, 3:49 p.m.) Review request for atlas and Madhan Neethiraj. Bugs: ATLAS-2184 https://issues.apache.org/jira/browse/ATLAS-2184 Repository: atlas Description ------- Search parameters in basic search now include is_null, not_null operators which can prove useful in scenarios where user is interested in checking the presence/absence of certain entity attributes Diffs (updated) ----- intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java a7a71b78 repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java b380e1e4 repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 18d77ee7 Diff: https://reviews.apache.org/r/62679/diff/3/ Changes: https://reviews.apache.org/r/62679/diff/2-3/ Testing ------- Tested using various combinations of attributes and IS_NULL/NOT_NULL operator via REST client/ curl Thanks, Apoorv Naik --===============7508711854437307403==--