Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 746D2200D0E for ; Tue, 26 Sep 2017 14:55:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 72E6A1609C1; Tue, 26 Sep 2017 12:55:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B57BC1609B4 for ; Tue, 26 Sep 2017 14:55:10 +0200 (CEST) Received: (qmail 1829 invoked by uid 500); 26 Sep 2017 12:55:09 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 1816 invoked by uid 99); 26 Sep 2017 12:55:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Sep 2017 12:55:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0B2261A3E3C; Tue, 26 Sep 2017 12:55:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.5 X-Spam-Level: *** X-Spam-Status: No, score=3.5 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id BIfbdZVqNaLE; Tue, 26 Sep 2017 12:55:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1735D60D33; Tue, 26 Sep 2017 12:55:07 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 69CE1E00A7; Tue, 26 Sep 2017 12:55:06 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 52F7FC414F1; Tue, 26 Sep 2017 12:55:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3068077436680725186==" MIME-Version: 1.0 Subject: Re: Review Request 62559: ATLAS-2168 : When a second search is fired in between the pages of the first search results , offset is not reset to 0 From: Nixon Rodrigues To: Ashutosh Mestry , Sharmadha Sainath , Madhan Neethiraj , Nixon Rodrigues Cc: keval bhatt , atlas Date: Tue, 26 Sep 2017 12:55:06 -0000 Message-ID: <20170926125506.42295.65749@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Nixon Rodrigues X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62559/ X-Sender: Nixon Rodrigues X-ReviewBoard-ShipIt: 1 References: <20170926071217.42296.16242@reviews-vm2.apache.org> In-Reply-To: <20170926071217.42296.16242@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Nixon Rodrigues X-ReviewRequest-Repository: atlas archived-at: Tue, 26 Sep 2017 12:55:11 -0000 --===============3068077436680725186== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62559/#review186244 ----------------------------------------------------------- Ship it! Ship It! - Nixon Rodrigues On Sept. 26, 2017, 7:12 a.m., keval bhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62559/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2017, 7:12 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath. > > > Bugs: ATLAS-2168 > https://issues.apache.org/jira/browse/ATLAS-2168 > > > Repository: atlas > > > Description > ------- > > 1. Created 8 hive_table entities. > 2. Created 3 hdfs_path entities. > 3. Searched for typename = hive_table , with page limit = 3. > 4. Navigated to page 3 which had 2 hive_table entities. Now offset is 6 and limit is 3. > 5. Now fired basic search typename = hdfs_path. (without clicking Clear). > 6. Expected result table would list 3 hdfs_path entities. But no results were fetched. Since offset is still set to > 7. If Clear button was clicked before making the hdfs_path query , offset is set to 0. > > > Diffs > ----- > > dashboardv2/public/js/views/search/SearchLayoutView.js b032ea9 > > > Diff: https://reviews.apache.org/r/62559/diff/1/ > > > Testing > ------- > > Tested by changing tag/query/type UI is resetting offset to 0 > > > Thanks, > > keval bhatt > > --===============3068077436680725186==--