Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id ECF47200D0E for ; Tue, 26 Sep 2017 14:53:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E87111609C1; Tue, 26 Sep 2017 12:53:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 396241609B4 for ; Tue, 26 Sep 2017 14:53:07 +0200 (CEST) Received: (qmail 88613 invoked by uid 500); 26 Sep 2017 12:53:06 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 88601 invoked by uid 99); 26 Sep 2017 12:53:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Sep 2017 12:53:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A54DD1829CB; Tue, 26 Sep 2017 12:53:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id CnZQhdXnzvLA; Tue, 26 Sep 2017 12:53:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2CE035FB62; Tue, 26 Sep 2017 12:53:04 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8A4B2E00A7; Tue, 26 Sep 2017 12:53:03 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 29F96C414F1; Tue, 26 Sep 2017 12:53:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2339234830170634265==" MIME-Version: 1.0 Subject: Re: Review Request 62561: ATLAS-2153 : UI : Adding more columns to the search table masks the "Remove tag" button From: Nixon Rodrigues To: Apoorv Naik , Sharmadha Sainath , Madhan Neethiraj , Ashutosh Mestry , Nixon Rodrigues Cc: keval bhatt , atlas Date: Tue, 26 Sep 2017 12:53:01 -0000 Message-ID: <20170926125301.42296.10257@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Nixon Rodrigues X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62561/ X-Sender: Nixon Rodrigues X-ReviewBoard-ShipIt: 1 References: <20170926072022.42294.30917@reviews-vm2.apache.org> In-Reply-To: <20170926072022.42294.30917@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Nixon Rodrigues X-ReviewRequest-Repository: atlas archived-at: Tue, 26 Sep 2017 12:53:08 -0000 --===============2339234830170634265== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62561/#review186242 ----------------------------------------------------------- Ship it! Ship It! - Nixon Rodrigues On Sept. 26, 2017, 7:20 a.m., keval bhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62561/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2017, 7:20 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath. > > > Bugs: ATLAS-2153 > https://issues.apache.org/jira/browse/ATLAS-2153 > > > Repository: atlas > > > Description > ------- > > For basic search typename = hive_table , 20 attributes can be added in the columns filter. When more attributes are added , "Remove Tag" (Cross button) on the Tag under Tags column is masked. This happens when the screen size is less and more columns are added. When columns are removed , Remove button shows up again. > > > Diffs > ----- > > dashboardv2/public/css/scss/form.scss b83fb9c > > > Diff: https://reviews.apache.org/r/62561/diff/1/ > > > Testing > ------- > > Tested with small screen and also tested with adding more columns in search table. > > > Thanks, > > keval bhatt > > --===============2339234830170634265==--