Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.apache.org
Content-Type: multipart/alternative;
 boundary="===============7559413302798720253=="
MIME-Version: 1.0
Subject: Re: Review Request 62382: ATLAS-2144 Add Knox x-forwarded path to
 Atlas base URL when Atlas is access via knox proxy
From: Nixon Rodrigues <nixon.rodrigues@freestoneinfotech.com>
To: Apoorv Naik <naik.apoorv@gmail.com>, keval bhatt <kbhatt@apache.org>,
 Madhan Neethiraj <madhan@apache.org>,
 Ashutosh Mestry <amestry@hortonworks.com>,
 Sarath Subramanian <sarath@apache.org>
Cc: atlas <dev@atlas.incubator.apache.org>,
 Nixon Rodrigues <nixon.rodrigues@freestoneinfotech.com>
Date: Fri, 22 Sep 2017 17:32:39 -0000
Message-ID: <20170922173239.9074.6861@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Nixon Rodrigues <noreply@reviews.apache.org>
References: <20170918130603.55959.69044@reviews-vm2.apache.org>
In-Reply-To: <20170918130603.55959.69044@reviews-vm2.apache.org>
Reply-To: Nixon Rodrigues <nixon.rodrigues@freestoneinfotech.com>
archived-at: Fri, 22 Sep 2017 17:32:44 -0000

--===============7559413302798720253==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62382/
-----------------------------------------------------------

(Updated Sept. 22, 2017, 5:32 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.


Changes
-------

Handled Review comments and changes suggested by Aushutosh Mestry.
Please review.


Bugs: ATLAS-2144
    https://issues.apache.org/jira/browse/ATLAS-2144


Repository: atlas


Description
-------

This patch includes fix to add Knox x-forwarded path to Atlas base URL when Atlas is access via knox proxy.

Also the changed the httpSecurity filter precendence between SSOFilter and basicFilter.
When request dispatched from knox proxy is landed in atlas with basic header and hadoopJwt cookie header, the basicFilter is invoked first before ssoFilter causing issue in SSO login.


Diffs (updated)
-----

  webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java 665fa34 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 3bec838 


Diff: https://reviews.apache.org/r/62382/diff/2/

Changes: https://reviews.apache.org/r/62382/diff/1-2/


Testing
-------

Tested Atlas with knox authentication
Tested Atlas knox proxy with Form login and Knox SSO.
Tested Atlas form based Login
Tested Atlas api with basic and knox cookie header.


Thanks,

Nixon Rodrigues


--===============7559413302798720253==--