Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 70176200D04 for ; Mon, 11 Sep 2017 23:43:51 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6ECE61609C4; Mon, 11 Sep 2017 21:43:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B2DA31609B7 for ; Mon, 11 Sep 2017 23:43:50 +0200 (CEST) Received: (qmail 93909 invoked by uid 500); 11 Sep 2017 21:43:49 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 93898 invoked by uid 99); 11 Sep 2017 21:43:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Sep 2017 21:43:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 54DC5183D8B; Mon, 11 Sep 2017 21:43:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id h0QZGWEUSXya; Mon, 11 Sep 2017 21:43:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 27E105FD42; Mon, 11 Sep 2017 21:43:46 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BF68AE01D8; Mon, 11 Sep 2017 21:43:45 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 4E4B8C400BC; Mon, 11 Sep 2017 21:43:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0276326329727116667==" MIME-Version: 1.0 Subject: Re: Review Request 59821: ATLAS-1805:Provide an Atlas hook to send Hbase Namespace/Table/column family metadata to Atlas From: Ramesh Mani To: Madhan Neethiraj Cc: atlas , Ramesh Mani Date: Mon, 11 Sep 2017 21:43:43 -0000 Message-ID: <20170911214343.54187.7810@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Ramesh Mani X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59821/ X-Sender: Ramesh Mani References: <20170910070446.3776.62081@reviews-vm2.apache.org> In-Reply-To: <20170910070446.3776.62081@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java X-ReviewBoard-Diff-For: addons/hbase-bridge-shim/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java X-ReviewBoard-Diff-For: addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java X-ReviewBoard-Diff-For: addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml X-ReviewBoard-Diff-For: addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseOperationContext.java X-ReviewBoard-Diff-For: addons/models/patches/001-hbase_table_column_family_add_attribute.json X-ReviewBoard-Diff-For: addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookTest.java X-ReviewBoard-Diff-For: addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseDataTypes.java X-ReviewBoard-Diff-For: addons/hbase-bridge-shim/pom.xml X-ReviewBoard-Diff-For: addons/hbase-bridge/pom.xml X-ReviewBoard-Diff-For: addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessorBase.java Reply-To: Ramesh Mani X-ReviewRequest-Repository: atlas archived-at: Mon, 11 Sep 2017 21:43:51 -0000 --===============0276326329727116667== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59821/ ----------------------------------------------------------- (Updated Sept. 11, 2017, 9:43 p.m.) Review request for atlas and Madhan Neethiraj. Changes ------- Fixed review comments Bugs: ATLAS-1805 https://issues.apache.org/jira/browse/ATLAS-1805 Repository: atlas Description ------- ATLAS-1805: Provide an Atlas hook to send Hbase Namespace/Table/column family metadata to Atlas Diffs (updated) ----- addons/hbase-bridge-shim/pom.xml PRE-CREATION addons/hbase-bridge-shim/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION addons/hbase-bridge/pom.xml PRE-CREATION addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java PRE-CREATION addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessorBase.java PRE-CREATION addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseDataTypes.java PRE-CREATION addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseOperationContext.java PRE-CREATION addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml PRE-CREATION addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookTest.java PRE-CREATION addons/models/1060-hbase_model.json 3e46e06 addons/models/patches/001-hbase_table_column_family_add_attribute.json PRE-CREATION distro/src/main/assemblies/standalone-package.xml 215cb23 pom.xml 157122a Diff: https://reviews.apache.org/r/59821/diff/5/ Changes: https://reviews.apache.org/r/59821/diff/4-5/ Testing ------- * Review comments fixed with 2 exceptions whcih I have commented on * Added an IT test * Testing done in LOCAL VM Thanks, Ramesh Mani --===============0276326329727116667==--