Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.apache.org
Content-Type: multipart/alternative;
 boundary="===============3960828566195645145=="
MIME-Version: 1.0
Subject: Re: Review Request 61200: ATLAS-1996: Log4J Default Configuration
 Updated
From: Ashutosh Mestry <amestry@hortonworks.com>
To: Madhan Neethiraj <madhan@apache.org>
Cc: Ashutosh Mestry <amestry@hortonworks.com>,
 atlas <dev@atlas.incubator.apache.org>, Sarath Subramanian <sarath@apache.org>
Date: Fri, 08 Sep 2017 16:28:07 -0000
Message-ID: <20170908162807.9625.98283@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Ashutosh Mestry <noreply@reviews.apache.org>
References: <20170907173029.39550.19394@reviews-vm2.apache.org>
In-Reply-To: <20170907173029.39550.19394@reviews-vm2.apache.org>
Reply-To: Ashutosh Mestry <amestry@hortonworks.com>
archived-at: Fri, 08 Sep 2017 16:28:15 -0000

--===============3960828566195645145==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61200/
-----------------------------------------------------------

(Updated Sept. 8, 2017, 4:28 p.m.)


Review request for atlas and Madhan Neethiraj.


Changes
-------

Updates include:
- Addressed review comment.


Bugs: ATLAS-1996
    https://issues.apache.org/jira/browse/ATLAS-1996


Repository: atlas


Description
-------

**Problem**
Existing log4J configuration did not include max size parameter. This caused logs to grow making it hard for human log readers.

Another contributing factor to log size growth is TitanDB's _IndexSerializer_. When this is used, the query conversion from graph query to indexed query is written as info log entry.

With the recent changes, many more index queries are used, thus contributing to growth of log files.

**Solution**

Added maxFileSize parameter.
Changed _com.thinkaurelius.titan_ log level to _warn_.

**Additional Info**
Defaults need to be set in _Ambari_ so that they reflect correctly as part of deployment.


Diffs (updated)
-----

  addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml c1184e5 
  distro/src/conf/atlas-log4j.xml a0ef6a9 
  typesystem/src/main/resources/atlas-log4j.xml c30403e 


Diff: https://reviews.apache.org/r/61200/diff/3/

Changes: https://reviews.apache.org/r/61200/diff/2-3/


Testing
-------

**Functional tests**
Observed configuration changes in the logs generated.


Thanks,

Ashutosh Mestry


--===============3960828566195645145==--