atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sar...@apache.org>
Subject Re: Review Request 61670: ATLAS-1880: Integration tests for the search functionality
Date Fri, 29 Sep 2017 19:20:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61670/#review186726
-----------------------------------------------------------




webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java
Lines 106 (patched)
<https://reviews.apache.org/r/61670/#comment263524>

    consider consolidating individual search-parameters json files into a small group of related
files - array of json objects.


- Sarath Subramanian


On Sept. 29, 2017, 11:46 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61670/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2017, 11:46 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-1954
>     https://issues.apache.org/jira/browse/ATLAS-1954
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ITs for ATLAS-1880
> 
> 
> Diffs
> -----
> 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java 5e1d1018 
>   client/pom.xml b065833e 
>   pom.xml f793321c 
>   repository/src/test/java/org/apache/atlas/discovery/EntityDiscoveryServiceTest.java
91d163ca 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java
cc1d2b3d 
>   repository/src/test/java/org/apache/atlas/utils/TestResourceFileUtils.java PRE-CREATION

>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java PRE-CREATION

>   webapp/src/test/resources/DefaultDB-3-New.zip PRE-CREATION 
>   webapp/src/test/resources/hive-db-50-tables.zip PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/combination/filter/hdfs_path-fooTag-queryText.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/combination/hdfs_path-fooTag-queryText.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/combination/hdfs_path-fooTag.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/combination/hive_column-col104.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/combination/hive_table-fooTag.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/combination/specialChars.json PRE-CREATION

>   webapp/src/test/resources/json/search-parameters/entity/filters/boolean/hive_table/eq.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/boolean/hive_table/neq.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/eq.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/gt.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/gte.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/lt.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/lte.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/date/hive_table/neq.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/eq.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/gt.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/gte.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/lt.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/lte.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/float/hive_table/neq.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/hive_table.json PRE-CREATION

>   webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/eq.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/gt.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/gte.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/lt.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/lte.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/int/hive_table/neq.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/eq.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/gt.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/gte.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/lt.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/lte.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/long/hive_table/neq.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_column/contains.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_column/endsWith.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_column/like.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/contains.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/endsWith.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/eq.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/in.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/like.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/neq.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/entity/filters/string/hive_table/startsWith.json
PRE-CREATION 
>   webapp/src/test/resources/json/search-parameters/tag/fooTag.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61670/diff/3/
> 
> 
> Testing
> -------
> 
> mvn clean package executes successfully
> Test runs from IDE successfully
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message